GH Action requesting ticket number doesn't recognize Core-#####

[peterwilsoncc]

The WordPress-Develop repository is configured to accept ticket in the form Core-##### on pull requests. These strings will be automatically linked to the ticket and picked up by the PR bot on trac.

As an example, view this ​pull request referencing Core-61864.

The GitHub action that adds a comment requesting PR descriptions include a link to tickets does not recognize these as links and will drop a comment requesting it be added.

Modifies the regex in the GitHub action commenting with a request to link to trac to recognize the Core- prefix.

Trac ticket: Core-61865

Modifies the regex in the GitHub action commenting with a request to link to trac to recognize the Core- prefix.

.

Modifies the regex in the GitHub action commenting with a request to link to trac to recognize the Core- prefix.

.

Modifies the regex in the GitHub action commenting with a request to link to trac to recognize the Core- prefix.

Modifies the regex in the GitHub action commenting with a request to link to a trac ticket to recognize the Core- prefix.

Modifies the regex in the GitHub action commenting with a request to link to a trac ticket to recognize the Core- prefix.

Modifies the regex in the GitHub action commenting with a request to link to a trac ticket to recognize the Core- prefix.

Modifies the regex in the GitHub action commenting with a request to link to a trac ticket to recognize the Core- prefix.

Modifies the regex in the GitHub action commenting with a request to link to a trac ticket to recognize the Core- prefix.

Core-61865

[peterwilsoncc]

I suspect the bot isn't picking up the issue number in the ​linked pull request due to the use of pull_request_target rather than pull_request.

@desrosj I suspect it will need a yolo commit and the crossing of fingers but it would be good to get your view once you return.

@martinkrcho I suspect it's because the action uses pull_request_target rather than pull_request for the action so it's running the version in trunk rather than this branch.

I'm not sure of a way to force this short of a yolo commit and testing it out.

I tested it on my own fork with the pull_request event and it seemed to work but it would be good to get a logic check.

[peterwilsoncc]

In 58901:

Build/test tools: Remove prompt for trac ticket referenced with Core- prefix.

Prevents the GitHub bot from posting a comment on pull requests requesting a trac ticket link if the ticket description includes a link via the Core- prefix, eg Core-61865.

The WordPress/WordPress-Develop repository is configured to automatically convert the text to a trac ticket link.

Props martinkrcho, peterwilsoncc.
Fixes #61865.

Merged r58901 / ​https://github.com/WordPress/wordpress-develop/commit/efee9258317fda297e11be7c5c418816fdd1f6bb

There are some security implications to consider, see ​https://runs-on.com/github-actions/pull-request-vs-pull-request-target/.

I'll need to check with someone but I think that's why it was changed at some point although I could be mistaken.

Core-61865

Works as expected. ​https://github.com/WordPress/wordpress-develop/actions/runs/10399050583/job/28797352177?pr=7199

[peterwilsoncc]

Reopening this to add ticket: as an accepted prefix, see ​[Meta13989]. @dd32 added the prefix to the accepted settings on WordPress-Develop yesterday.

Accepts ticket: as a prefix for linking to a trac ticket. This is also a permitted autolink reference.

Trac ticket: ticket:61865

[peterwilsoncc]

In 58939:

Build/test tools: Remove prompt for trac ticket referenced with ticket: prefix.

Prevents the GitHub bot from posting a comment on pull requests requesting a trac ticket link if the ticket description includes a link via the ticket: prefix, eg ticket:61865.

The WordPress/WordPress-Develop repository is configured to automatically convert the text to a trac ticket link.

Props dd32, peterwilsoncc.
Fixes #61865.

Merged r58939 / ​https://github.com/WordPress/wordpress-develop/commit/66febebdb966728a978a1b7ac4b4926ad544e72a

ticket:61865

Core-61865

https://core.trac.wordpress.org/ticket/61865

One last test.