Make WordPress Core

Opened 2 months ago

Last modified 8 weeks ago

#61885 new defect (bug)

Twenty Fifteen: Search Block button does not have theme's styling in the editor

Reported by: pitamdey's profile pitamdey Owned by:
Milestone: Future Release Priority: normal
Severity: normal Version:
Component: Bundled Theme Keywords: has-screenshots has-testing-info
Focuses: css Cc:

Description

In Theme Twenty Fifteen, Search Block button text is lowercase in editor and uppercase in frontend

Attachments (7)

Screenshot 2024-08-16 at 10.19.27 AM.png (231.2 KB) - added by pitamdey 2 months ago.
Editor View
Screenshot 2024-08-16 at 10.20.01 AM.png (352.2 KB) - added by pitamdey 2 months ago.
Frontend View
61885.patch (378 bytes) - added by pitamdey 2 months ago.
After applying this solution the issue is resolved
61885.2.patch (429 bytes) - added by viralsampat 2 months ago.
I have checked above mentioned issue and I have resolved it and added patch.
61885.3.patch (691 bytes) - added by shailu25 2 months ago.
Patch Updated.
61885.4.patch (658 bytes) - added by shailu25 2 months ago.
Corrected Search CSS Placement in editor-blocks.css
61885.5.patch (859 bytes) - added by pitamdey 8 weeks ago.
Updated Patch

Download all attachments as: .zip

Change History (11)

@pitamdey
2 months ago

After applying this solution the issue is resolved

#1 @narenin
2 months ago

  • Keywords has-testing-info added

Hi,

Test Report

Patch tested: https://core.trac.wordpress.org/attachment/ticket/61885/61885.patch

Environment:

OS: Windows
PHP: 8.2.12
WordPress: 6.6.1
Browser: Chrome
Theme: Twenty Fifteen (Version: 3.8)
Plugins: None activated
Actual Results:

✅ Before patch:
Backend: https://prnt.sc/hInRByb1ruU-
Frontend: https://prnt.sc/VFCDjlBcDP_t

✅ After patch:
Backend: https://prnt.sc/hInRByb1ruU-
Frontend: https://prnt.sc/E4kVg9ED-tdM

✅ Patch working well as desired solution.

@viralsampat
2 months ago

I have checked above mentioned issue and I have resolved it and added patch.

#2 @sabernhardt
2 months ago

  • Keywords needs-patch added
  • Milestone changed from Awaiting Review to Future Release
  • Summary changed from Twenty Fifteen : Search Block button text is lowercase in editor and uppercase in frontend to Twenty Fifteen: Search Block button does not have theme's styling in the editor

The Search button's colors and font are also wrong in the editor.

The editor-blocks stylesheet needs styles to match button styles on the front end.

/* Search */

.wp-block-search__button {
	background-color: #333;
	color: #fff;
	font-family: "Noto Sans", sans-serif;
	font-size: 14px;
	font-weight: 700;
	text-transform: uppercase;
}

@shailu25
2 months ago

Patch Updated.

#3 @shailu25
2 months ago

  • Keywords needs-patch removed

@shailu25
2 months ago

Corrected Search CSS Placement in editor-blocks.css

#4 @sabernhardt
8 weeks ago

These styles could fit better in the Widgets section (between Latest Posts and Colors).

Considering other elements of the Search block:

  • The label matches the front.
  • The input has a significantly different font-family. The editor appearance might benefit from (some of) these rules:
    .wp-block-search .wp-block-search__input {
      border-radius: 0;
      color: rgba(51, 51, 51, 0.7);
      font-family: "Noto Sans", sans-serif;
      font-size: 1em;
      padding: 0.5em;
    }
    

@pitamdey
8 weeks ago

Updated Patch

Note: See TracTickets for help on using tickets.