#61892 closed defect (bug) (fixed)
Enqueue `classic-theme-styles` earlier in editor styles
| Reported by: |
|
Owned by: |
|
|---|---|---|---|
| Milestone: | 6.8 | Priority: | normal |
| Severity: | normal | Version: | 6.1 |
| Component: | Themes | Keywords: | has-patch |
| Focuses: | Cc: |
Description
[54687] introduced a fallback stylesheet for Button block styles (and later File blocks) for both the front end and the editor. In the editor, that has been added within the body, after the theme's block styles.
That commit had quick fixes for Twenty Twelve and Twenty Twenty, but raising the specificity for those colors should have been unnecessary. Also, themes such as Twenty Fourteen—and non-Core themes—still have had a similar problem with the incorrect order (#61881, GB44731).
Change History (10)
This ticket was mentioned in PR #7205 on WordPress/wordpress-develop by @sabernhardt.
20 months ago
#1
- Keywords has-patch added
@sabernhardt commented on PR #7205:
20 months ago
#2
Related concerns, for other tickets:
- In the non-framed editor, stylesheets enqueued with the
enqueue_block_editor_assetshook still can be added beforeclassic-theme-styles. Trac 61591 should fix that for the bundled themes by using theenqueue_block_assetshook. - Twenty Ten shows the Button block links with white text in the iframe and gray in the non-framed editor, but the front end sets links to blue at a higher specificity:
a:link { color: #0066cc; }
This ticket was mentioned in Slack in #core by chaion07. View the logs.
18 months ago
#4
@
18 months ago
- Milestone changed from 6.7 to 6.8
6.7 RC1 is due out any moment, so unfortunately this one missed the deadline.
This ticket was mentioned in Slack in #core by audrasjb. View the logs.
14 months ago
#6
@
14 months ago
- Owner set to audrasjb
- Status changed from new to reviewing
Self assigning for review
This ticket was mentioned in Slack in #core by audrasjb. View the logs.
13 months ago
@sabernhardt commented on PR #7205:
13 months ago
#9
Committed in r59980
wp_enqueue_classic_theme_styles().enqueue_block_assetsaction instead of adding them in theblock_editor_settings_allfilter.wp_add_editor_classic_theme_styles()function.Trac 61892