Opened 6 months ago
Last modified 6 weeks ago
#61904 new defect (bug)
Twenty Nineteen : Social Icons Block's text decoration not matching in both side
Reported by: |
|
Owned by: | |
---|---|---|---|
Milestone: | Awaiting Review | Priority: | normal |
Severity: | normal | Version: | |
Component: | Bundled Theme | Keywords: | has-screenshots has-patch needs-testing has-testing-info |
Focuses: | css | Cc: |
Description
In Theme Twenty Nineteen, Social Icons Block's text does not have text-decoration at the editor but have text decoration underline in frontend. So In both side it looks different
Attachments (3)
Change History (12)
#2
@
6 months ago
- Keywords has-patch needs-testing added
I can confirm this issue so moving to testing.
#3
@
3 months ago
Test Report
Description
This report validates whether the indicated patch works as expected.
Patch tested: https://core.trac.wordpress.org/attachment/ticket/61904/61904.patch
Environment
- WordPress: 6.8-alpha-59274-src
- PHP: 8.2.25
- Server: nginx/1.27.2
- Database: mysqli (Server: 8.0.40 / Client: mysqlnd 8.2.25)
- Browser: Chrome 131.0.0.0
- OS: macOS
- Theme: Twenty Nineteen 3.0
- MU Plugins: None activated
- Plugins:
- Test Reports 1.2.0
Actual Results
- ❌ Issue not fully resolved by patch (patch failed to apply)
- The patch failed to apply due to formatting differences, including mismatched line numbers and whitespace changes. As a result, 8 out of 46 hunks failed, and the patch could not be fully applied automatically, generating a .rej file.
- ✅ Issue resolved with manual intervention
- After manually adding the following line, the issue was resolved as intended:
//! wp-block-social-links .wp-block-social-links .wp-block-social-link.wp-social-link .wp-block-social-link-anchor { text-decoration: none; }
Supplemental Artifacts
This ticket was mentioned in PR #7841 on WordPress/wordpress-develop by @sainathpoojary.
3 months ago
#4
This pull request fixes an issue in the Twenty Nineteen theme where social icons in the wp-block-social-links block appear without underlines in the editor but are incorrectly displayed with underlines on the frontend. This PR resolves the issue by adding a text-decoration: none; rule for anchor tags in the frontend, ensuring consistent styling with the editor.
Trac ticket: #61904
@rinkalpagdar commented on PR #7841:
3 months ago
#5
Hello @SainathPoojary
I have tested this PR change, it's working fine.
Thanks
This ticket was mentioned in Slack in #core-test by vishitshah. View the logs.
6 weeks ago
#8
@
6 weeks ago
- Keywords has-testing-info added
## Test Report
### Description
This report validates whether the indicated patch works as expected.
Patch tested: https://github.com/WordPress/wordpress-develop/pull/7841
### Environment
- WordPress: 6.8-alpha-20241119.172832
- PHP: 7.4.31-dev
- Server: PHP.wasm
- Database: WP_SQLite_Translator (Server: 5.5 / Client: 3.40.1)
- Browser: Chrome 131.0.0.0
- OS: Linux
- Theme: Twenty Nineteen 3.0
- MU Plugins: None activated
- Plugins:
- Test Reports 1.2.0
### Actual Results
- ❌ Issue is not fixed with the given patch
### Supplemental Artifacts
https://tinyurl.com/2d4kf6vj
#9
@
6 weeks ago
Bug Report
Description
The issue is resolved after applying the patch.
Environment
- WordPress: 6.7.1
- PHP: 8.1.23
- Server: nginx/1.16.0
- Database: mysqli (Server: 8.0.16 / Client: mysqlnd 8.1.23)
- Browser: Chrome 131.0.0.0
- OS: macOS
- Theme: Twenty Nineteen 3.0
- MU Plugins: None activated
Editor View