Make WordPress Core

Opened 6 months ago

Last modified 6 weeks ago

#61904 new defect (bug)

Twenty Nineteen : Social Icons Block's text decoration not matching in both side

Reported by: pitamdey's profile pitamdey Owned by:
Milestone: Awaiting Review Priority: normal
Severity: normal Version:
Component: Bundled Theme Keywords: has-screenshots has-patch needs-testing has-testing-info
Focuses: css Cc:

Description

In Theme Twenty Nineteen, Social Icons Block's text does not have text-decoration at the editor but have text decoration underline in frontend. So In both side it looks different

Attachments (3)

Screenshot 2024-08-21 at 6.28.21 PM.png (227.2 KB) - added by pitamdey 6 months ago.
Editor View
Screenshot 2024-08-21 at 6.29.07 PM.png (198.5 KB) - added by pitamdey 6 months ago.
Frontend View
61904.patch (11.7 KB) - added by pitamdey 6 months ago.
After applying this solution the issue is resolved

Download all attachments as: .zip

Change History (12)

@pitamdey
6 months ago

After applying this solution the issue is resolved

#1 @pitamdey
6 months ago

I have also formatted the code of the particular file.

#2 @karmatosed
6 months ago

  • Keywords has-patch needs-testing added

I can confirm this issue so moving to testing.

#3 @sainathpoojary
3 months ago

Test Report

Description

This report validates whether the indicated patch works as expected.

Patch tested: https://core.trac.wordpress.org/attachment/ticket/61904/61904.patch

Environment

  • WordPress: 6.8-alpha-59274-src
  • PHP: 8.2.25
  • Server: nginx/1.27.2
  • Database: mysqli (Server: 8.0.40 / Client: mysqlnd 8.2.25)
  • Browser: Chrome 131.0.0.0
  • OS: macOS
  • Theme: Twenty Nineteen 3.0
  • MU Plugins: None activated
  • Plugins:
    • Test Reports 1.2.0

Actual Results

  1. ❌ Issue not fully resolved by patch (patch failed to apply)
  • The patch failed to apply due to formatting differences, including mismatched line numbers and whitespace changes. As a result, 8 out of 46 hunks failed, and the patch could not be fully applied automatically, generating a .rej file.
  1. ✅ Issue resolved with manual intervention
  • After manually adding the following line, the issue was resolved as intended:
//! wp-block-social-links
.wp-block-social-links .wp-block-social-link.wp-social-link .wp-block-social-link-anchor {
    text-decoration: none;
}

Supplemental Artifacts

Patch: https://utfs.io/f/PL8E4NiPUWyOGCntO8NEeschquBM6yNU3LCFxWSw4rTfmliR

This ticket was mentioned in PR #7841 on WordPress/wordpress-develop by @sainathpoojary.


3 months ago
#4

This pull request fixes an issue in the Twenty Nineteen theme where social icons in the wp-block-social-links block appear without underlines in the editor but are incorrectly displayed with underlines on the frontend. This PR resolves the issue by adding a text-decoration: none; rule for anchor tags in the frontend, ensuring consistent styling with the editor.

Trac ticket: #61904

### Before:
https://github.com/user-attachments/assets/375a317a-36c1-40e7-a977-ba6423cc76c2

### After:
https://github.com/user-attachments/assets/dddd9514-9605-4263-a88d-68b47c511ab8

@rinkalpagdar commented on PR #7841:


3 months ago
#5

Hello @SainathPoojary
I have tested this PR change, it's working fine.
Thanks

#6 @rinkalpagdar
3 months ago

Last edited 3 months ago by rinkalpagdar (previous) (diff)

This ticket was mentioned in Slack in #core-test by vishitshah. View the logs.


6 weeks ago

#8 @vishitshah
6 weeks ago

  • Keywords has-testing-info added

## Test Report
### Description
This report validates whether the indicated patch works as expected.

Patch tested: https://github.com/WordPress/wordpress-develop/pull/7841

### Environment

  • WordPress: 6.8-alpha-20241119.172832
  • PHP: 7.4.31-dev
  • Server: PHP.wasm
  • Database: WP_SQLite_Translator (Server: 5.5 / Client: 3.40.1)
  • Browser: Chrome 131.0.0.0
  • OS: Linux
  • Theme: Twenty Nineteen 3.0
  • MU Plugins: None activated
  • Plugins:
    • Test Reports 1.2.0

### Actual Results

  1. ❌ Issue is not fixed with the given patch

### Supplemental Artifacts
https://tinyurl.com/2d4kf6vj

#9 @akshitvijay
6 weeks ago

Bug Report

Description

The issue is resolved after applying the patch.

Environment

  • WordPress: 6.7.1
  • PHP: 8.1.23
  • Server: nginx/1.16.0
  • Database: mysqli (Server: 8.0.16 / Client: mysqlnd 8.1.23)
  • Browser: Chrome 131.0.0.0
  • OS: macOS
  • Theme: Twenty Nineteen 3.0
  • MU Plugins: None activated

Before Applying Patch

https://paste.pics/ad7de81187bac10361f1877b19b12d1f
https://paste.pics/c63dcd52a717b4a55e2d3e1a74f46f75

After Applying Patch

https://paste.pics/81654c443a9a71d6d3961f78dc6c6906
https://paste.pics/1b358d37933e749b24acba87796aa32f

Note: See TracTickets for help on using tickets.