Twenty Nineteen: Social Icons block's text is underlined in the post content

[pitamdey]

In Theme Twenty Nineteen, Social Icons Block's text does not have text-decoration at the editor but have text decoration underline in frontend. So In both side it looks different

[pitamdey]

Editor View

[pitamdey]

Frontend View

[pitamdey]

After applying this solution the issue is resolved

[pitamdey]

I have also formatted the code of the particular file.

[karmatosed]

I can confirm this issue so moving to testing.

[sainathpoojary]

Test Report

Description

This report validates whether the indicated patch works as expected.

Patch tested: https://core.trac.wordpress.org/attachment/ticket/61904/61904.patch

Environment

• WordPress: 6.8-alpha-59274-src
• PHP: 8.2.25
• Server: nginx/1.27.2
• Database: mysqli (Server: 8.0.40 / Client: mysqlnd 8.2.25)
• Browser: Chrome 131.0.0.0
• OS: macOS
• Theme: Twenty Nineteen 3.0
• MU Plugins: None activated
• Plugins:
  • Test Reports 1.2.0

Actual Results

1. ❌ Issue not fully resolved by patch (patch failed to apply)

• The patch failed to apply due to formatting differences, including mismatched line numbers and whitespace changes. As a result, 8 out of 46 hunks failed, and the patch could not be fully applied automatically, generating a .rej file.

2. ✅ Issue resolved with manual intervention

• After manually adding the following line, the issue was resolved as intended:

//! wp-block-social-links
.wp-block-social-links .wp-block-social-link.wp-social-link .wp-block-social-link-anchor {
    text-decoration: none;
}

Supplemental Artifacts

Patch:

This pull request fixes an issue in the Twenty Nineteen theme where social icons in the wp-block-social-links block appear without underlines in the editor but are incorrectly displayed with underlines on the frontend. This PR resolves the issue by adding a text-decoration: none; rule for anchor tags in the frontend, ensuring consistent styling with the editor.

Trac ticket: #61904

### Before:

### After:

Hello @SainathPoojary
I have tested this PR change, it's working fine.
Thanks

[rinkalpagdar]

Test Report

---

After applying the change mentioned in the PR its solved the issue.

[vishitshah]

## Test Report
### Description
This report validates whether the indicated patch works as expected.

Patch tested: ​https://github.com/WordPress/wordpress-develop/pull/7841

### Environment

• WordPress: 6.8-alpha-20241119.172832
• PHP: 7.4.31-dev
• Server: PHP.wasm
• Database: WP_SQLite_Translator (Server: 5.5 / Client: 3.40.1)
• Browser: Chrome 131.0.0.0
• OS: Linux
• Theme: Twenty Nineteen 3.0
• MU Plugins: None activated
• Plugins:
  • Test Reports 1.2.0

### Actual Results

1. ❌ Issue is not fixed with the given patch

### Supplemental Artifacts
​https://tinyurl.com/2d4kf6vj

[akshitvijay]

Bug Report

Description

The issue is resolved after applying the patch.

Environment

• WordPress: 6.7.1
• PHP: 8.1.23
• Server: nginx/1.16.0
• Database: mysqli (Server: 8.0.16 / Client: mysqlnd 8.1.23)
• Browser: Chrome 131.0.0.0
• OS: macOS
• Theme: Twenty Nineteen 3.0
• MU Plugins: None activated

Before Applying Patch

After Applying Patch

[shraddhagore]

Patch tested (PR): ​https://github.com/WordPress/wordpress-develop/pull/7841

Environment:
WordPress: 6.8-alpha-20241119.172832
Theme: Twenty Nineteen, 3.0
Browser: Google Chrome
OS: Windows 11

Media:
Editor: ​https://prnt.sc/l98rdLBqWskb
Site: ​https://prnt.sc/42rVg1ZYr45k

Comments:
The patch (PR) isn't working. The social icons continue to have an underlined style on the site.

[sabernhardt]

Steps to reproduce:

1. Activate Twenty Nineteen.
2. Create (or edit) a post.
3. Add a Social Icons block, and activate its "Show text" setting.
4. Add an icon, such as WordPress, inside the Social Icons block. Add a URL in the link field and press Enter.
5. Save and view the post on the front end.

Hey @sabernhardt,

I have implemented the requested changes and rebased the branch. After rebasing, I noticed that there’s some extra margin on the social icon button. Should I open a issue for it?

Additionally, while running npm install, I encountered a deprecation issue related to node-sass. If this needs to be addressed, I’d be happy to work on it.

The separate ​Social Icons block margin issue should be fixed in Gutenberg 20.4.

I have had node-sass deprecation warnings too. In a previous installation I fixed it with the rebuild command, but I have not solved it in my new environment yet. I tried ​replacing with `sass` last year, but I did not like how much it changed in the compiled stylesheets just with the package changes. (Adding special rules might help if the switch is necessary.)

[sainathpoojary]

Hi @sabernhardt, just a quick follow-up on this ticket. It looks like it’s been inactive for a while after approval. Let me know if anything else is needed to move the ​patch forward. Thanks!

[hmbashar]

Test Report

Description

Hi, I see that there is no underline without installing any patch; by default, it works fine for me.

Environment

• WordPress: 6.9-alpha-60093-src
• PHP: 8.2.28
• Server: nginx/1.25.4
• Database: mysqli (Server: 8.0.41 / Client: mysqlnd 8.2.28)
• Browser: Chrome 137.0.0.0
• OS: macOS
• Theme: Twenty Nineteen 3.1
• MU Plugins: None activated
• Plugins:
  • Test Reports 1.2.0

[huzaifaalmesbah]

Test Report

Patch tested: ​https://github.com/WordPress/wordpress-develop/pull/7841

Environment

• WordPress: 6.9-alpha-60093-src
• PHP: 8.2.28
• Server: nginx/1.27.5
• Database: mysqli (Server: 9.3.0 / Client: mysqlnd 8.2.28)
• Browser: Chrome 137.0.0.0
• OS: macOS
• Theme: Twenty Nineteen 3.1
• MU Plugins: None activated
• Plugins:
  • Test Reports 1.2.0

Actual Results

1. ✅ Issue resolved with patch.

Screenshots

Before Apply Patch	After Apply Patch ✅

[iamshashank]

Test Report

Description

✅ This report validates that the indicated patch works as expected.

Patch tested: ​https://github.com/WordPress/wordpress-develop/pull/7841.diff

Environment

• WordPress: 6.8.1
• PHP: 8.2.27
• Server: nginx/1.26.1
• Database: mysqli (Server: 8.0.35 / Client: mysqlnd 8.2.27)
• Browser: Chrome 137.0.0.0
• OS: macOS
• Theme: Twenty Nineteen 3.1
• MU Plugins: None activated
• Plugins:
  • Test Reports 1.2.0

Actual Results

1. ✅ Issue resolved with patch.

Screenshots

Before the Patch
After applying Patch