Incorrect schema for global styles REST API endpoint

[johnbillion]

The schema for the wp/v2/global-styles/{id} REST API endpoint declares the id property as a string, but it is in fact an integer containing the post ID for the global style.

Trac ticket: https://core.trac.wordpress.org/ticket/61911

@narenin Thanks for the PR. int isn't a valid type in JSON schema.

@johnbillion Thanks for the review, I have updated the same to integer, please check.

This is slightly weird because the value does have a sanitize_callback registered for it which calls urldecode, which seems like an indication that the value is supposed to be a string. Are we sure this is supposed to be an integer? If so, we should probably also be removing the sanitize_callback.

Thanks @johnbillion @TimothyBJacobs for your feedback's, I have implemented the same, could you please take a look.

Thanks @johnbillion @TimothyBJacobs for your feedback's, I have implemented the same, could you please take a look.

Thanks @johnbillion @TimothyBJacobs for your feedback's, I have implemented the same, could you please take a look.

[johnbillion]

This is close but there are some failing tests in the associated PR that need to be investigated.

[mikinc860]

@johnbillion The regular expression for the id parameter can be simplified. The pattern (?P<id>[\/\d+]+) implies that the id can contain slashes, which is unusual for an integer ID. It would be more appropriate to use (?P<id>\d+) to match only digits.

@johnbillion @TimothyBJacobs are you available to review the edited PR? Thanks!

@narenin Want to take a look at these failing unit tests?

Hi @johnbillion. I have added the unit tests and updated the existing test files. Now, all the tests are passing. Let me know if the changes look good to you. 🙌🏻