Opened 6 weeks ago
Closed 6 weeks ago
#61913 closed defect (bug) (duplicate)
Twenty Nineteen: Details block text color is not applying when we set background.
Reported by: | viralsampat | Owned by: | |
---|---|---|---|
Milestone: | Priority: | normal | |
Severity: | normal | Version: | |
Component: | Bundled Theme | Keywords: | has-patch 2nd-opinion |
Focuses: | css | Cc: |
Description
Hello Team,
I have reviewed "Details Block" and found that its text color not change when we set its background color based on requirement.
I think that it should be change based on requirement on editor & front-end sides.
For, better understanding, here I have attached its screenshots.
Thanks,
Attachments (6)
Change History (9)
@
6 weeks ago
I have checked above mentioned issue and I have resolved it and added patch. Also, I have attached screenshot after resolved this issue.
#1
@
6 weeks ago
- Keywords 2nd-opinion added; dev-feedback removed
There are a few factors here which I think need consideration.
- You can actually change the text color of the title.
- You can change the text color of the paragraph block 'if' click into the details block.
As a result because of the grouping I think what the issue is here there could be an expectation for globally changing all colors. That said a paragraph block should in theory work independently.
You can see in my attached screenshot the issue in more in-depth. Whatever solution could create issues for independent controls, which would also be an issue.
#3
@
6 weeks ago
- Milestone Awaiting Review deleted
- Resolution set to duplicate
- Status changed from new to closed
- Summary changed from Twenty Nineteen theme: Detail block text color is not applying when we set background. to Twenty Nineteen: Details block text color is not applying when we set background.
I'm closing this to keep the discussion about the theme's automatic contrast text colors on #49931. The same patch should affect the Details block too.
Back-end: