Make WordPress Core

Opened 2 years ago

Closed 2 years ago

#61913 closed defect (bug) (duplicate)

Twenty Nineteen: Details block text color is not applying when we set background.

Reported by: viralsampat Owned by:
Priority: normal Milestone:
Component: Bundled Theme Version:
Severity: normal Keywords: has-patch 2nd-opinion
Cc: Focuses: css

Description

Hello Team,

I have reviewed "Details Block" and found that its text color not change when we set its background color based on requirement.

I think that it should be change based on requirement on editor & front-end sides.

For, better understanding, here I have attached its screenshots.

Thanks,

Attachments (6)

twenty-nineteen-detail-block-editor.png​ (260.3 KB ) - added by viralsampat 2 years ago.
Back-end:
twenty-nineteen-detail-block-front-end.png​ (183.2 KB ) - added by viralsampat 2 years ago.
Front-end:
61913.patch​ (1.0 KB ) - added by viralsampat 2 years ago.
I have checked above mentioned issue and I have resolved it and added patch. Also, I have attached screenshot after resolved this issue.
after-resolved-twenty-nineteen-detail-block-editor.png​ (244.0 KB ) - added by viralsampat 2 years ago.
After resolved issue Back-end:
after-resolved-twenty-nineteen-detail-block-front-end.png​ (198.3 KB ) - added by viralsampat 2 years ago.
After resolved issue front-end:
SCR-20240825-iwxn.png​ (153.3 KB ) - added by karmatosed 2 years ago.

Download all attachments as: .zip

Change History (9)

@viralsampat
2 years ago

I have checked above mentioned issue and I have resolved it and added patch. Also, I have attached screenshot after resolved this issue.

@viralsampat
2 years ago

After resolved issue Back-end:

@viralsampat
2 years ago

After resolved issue front-end:

#1 @karmatosed
2 years ago

  • Keywords 2nd-opinion added; dev-feedback removed

There are a few factors here which I think need consideration.

  • You can actually change the text color of the title.
  • You can change the text color of the paragraph block 'if' click into the details block.

As a result because of the grouping I think what the issue is here there could be an expectation for globally changing all colors. That said a paragraph block should in theory work independently.

You can see in my attached screenshot the issue in more in-depth. Whatever solution could create issues for independent controls, which would also be an issue.

#2 @karmatosed
2 years ago

  • Keywords needs-testing removed

#3 @sabernhardt
2 years ago

  • Milestone Awaiting Review
  • Resolution → duplicate
  • Status new → closed
  • Summary Twenty Nineteen theme: Detail block text color is not applying when we set background. → Twenty Nineteen: Details block text color is not applying when we set background.

I'm closing this to keep the discussion about the theme's automatic contrast text colors on #49931. The same patch should affect the Details block too.

Note: See TracTickets for help on using tickets.