Context Navigation

← Previous Ticket
Next Ticket →

#61933 closed defect (bug) (fixed)

Twenty Nineteen : Remove the use of empty rulesets

Reported by:	pitamdey	Owned by:	SergeyBiryukov
Priority:	normal	Milestone:	6.7
Component:	Bundled Theme	Version:	5.0
Severity:	normal	Keywords:	has-patch commit has-test-info
Cc:		Focuses:

Description

In Twenty Nineteen, In Scss file I can see a lint error of "Do not use empty rulesets" i.e. The class is called but it is blank, no style property is applied.

I have added a patch for it

Attachments (1)

61933.patch (1.3 KB ) - added by pitamdey 23 months ago.: Patch for this issue

Download all attachments as: .zip

Change History (5)

@pitamdey
23 months ago

Attachment 61933.patch added

Patch for this issue

#1 @mukesh27
23 months ago

Keywords has-patch commit added
Milestone Awaiting Review → 6.7
Version → 5.0

Nice catch.

Move to milestone for commit consideration.

#2 @narenin
23 months ago

Keywords has-testing-info added

Hi @pitamdey

Test Report

Patch tested: https://core.trac.wordpress.org/attachment/ticket/61933/61933.patch

Environment:

OS: Windows
PHP: 8.2.12
WordPress: 6.6.1
Browser: Chrome
Theme: Twenty Nineteen (Version: 2.9)
Plugins: None activated

Actual Results:

✅ Patch working well as desired solution.

#3 @SergeyBiryukov
23 months ago

Owner set to SergeyBiryukov
Resolution → fixed
Status new → closed

In 58943:

Twenty Nineteen: Remove the use of empty rulesets.

Follow-up to [43808].

Props pitamdey, mukesh27, narenin.
Fixes #61933.

#4 @wordpressdotorg
14 months ago

Keywords has-test-info added; has-testing-info removed

Note: See TracTickets for help on using tickets.

Download in other formats:

Make WordPress Core