WordPress.org
Get WordPress

Make WordPress Core

Opened 2 weeks ago

Closed 2 weeks ago

#61933 closed defect (bug) (fixed)

Twenty Nineteen : Remove the use of empty rulesets

Reported by: pitamdey's profile pitamdey Owned by: sergeybiryukov's profile SergeyBiryukov
Milestone: 6.7 Priority: normal
Severity: normal Version: 5.0
Component: Bundled Theme Keywords: has-patch commit has-testing-info
Focuses: Cc:

Description

In Twenty Nineteen, In Scss file I can see a lint error of "Do not use empty rulesets" i.e. The class is called but it is blank, no style property is applied.

I have added a patch for it

Attachments (1)

61933.patch​ (1.3 KB) - added by pitamdey 2 weeks ago.
Patch for this issue

Download all attachments as: .zip

Change History (4)

@pitamdey
2 weeks ago

Patch for this issue

#1 @mukesh27
2 weeks ago

  • Keywords has-patch commit added
  • Milestone changed from Awaiting Review to 6.7
  • Version set to 5.0

Nice catch.

Move to milestone for commit consideration.

#2 @narenin
2 weeks ago

  • Keywords has-testing-info added

Hi @pitamdey

Test Report

Patch tested: https://core.trac.wordpress.org/attachment/ticket/61933/61933.patch

Environment:

OS: Windows
PHP: 8.2.12
WordPress: 6.6.1
Browser: Chrome
Theme: Twenty Nineteen (Version: 2.9)
Plugins: None activated

Actual Results:

✅ Patch working well as desired solution.

#3 @SergeyBiryukov
2 weeks ago

  • Owner set to SergeyBiryukov
  • Resolution set to fixed
  • Status changed from new to closed

In 58943:

Twenty Nineteen: Remove the use of empty rulesets.

Follow-up to [43808].

Props pitamdey, mukesh27, narenin.
Fixes #61933.

Note: See TracTickets for help on using tickets.