Make WordPress Core

Changes between Initial Version and Version 1 of Ticket #61939, comment 3


Ignore:
Timestamp:
08/27/2024 09:58:34 PM (7 months ago)
Author:
flixos90
Comment:

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #61939, comment 3

    initial v1  
    22> Just noting that changing these values in the upgrade routine and the existing unit tests were an intentional omission when the values were updated in #61045.
    33
    4 Thanks for raising that. Looking at that changeset [58105], it looks like some of the `add_option()` / `update_option()` calls were updated to use `'on'|'off'`, which doesn't look right. They should probably be updated here too to use the booleans. `'on'|'off'` should only be used when dealing with the database values directly. I'll update the PR https://github.com/WordPress/wordpress-develop/pull/7251 to replace the relevant `'on'|'off'` as well.
     4Thanks for raising that. ~~Looking at that changeset [58105], it looks like some of the `add_option()` / `update_option()` calls were updated to use `'on'|'off'`, which doesn't look right. They should probably be updated here too to use the booleans. `'on'|'off'` should only be used when dealing with the database values directly. I'll update the PR https://github.com/WordPress/wordpress-develop/pull/7251 to replace the relevant `'on'|'off'` as well.~~ **Update:** Never mind, it looks like those were already fixed in another subsequent changeset. :)
    55
    66> [...]