Make WordPress Core

Opened 5 months ago

Closed 4 months ago

#61951 closed defect (bug) (fixed)

TT3 and TT4: make template heading text translatable

Reported by: sabernhardt's profile sabernhardt Owned by: poena's profile poena
Milestone: 6.7 Priority: normal
Severity: normal Version:
Component: Bundled Theme Keywords: has-patch commit
Focuses: Cc:

Description (last modified by sabernhardt)

Follow-up to #60298

Twenty Twenty-Three still has an untranslatable heading "Mindblown: a blog about philosophy." in home.html.

Twenty Twenty-Four has "Posts" in its index.html template.

Attachments (2)

61591.diff (4.0 KB) - added by sabernhardt 5 months ago.
creating hidden templates for the headings so they can use PHP
61951.patch (3.2 KB) - added by iflairwebtechnologies 5 months ago.
Fixed TT3 and TT4 template heading text translatable

Download all attachments as: .zip

Change History (11)

@sabernhardt
5 months ago

creating hidden templates for the headings so they can use PHP

@iflairwebtechnologies
5 months ago

Fixed TT3 and TT4 template heading text translatable

#2 @sabernhardt
5 months ago

  • Description modified (diff)

#3 @karmatosed
5 months ago

  • Keywords commit added
  • Milestone changed from Awaiting Review to 6.7

I am going to pick the first patch as the second @iflairwebtechnologies seems to also have additional files in it. Thank you for both patches though. I am going to test and look to committing this.

#4 @karmatosed
5 months ago

  • Keywords needs-testing added; commit removed

For now, because this adds templates even though hidden, I think having more testing might be good so removing commit and adding testing. I will keep the milestone.

This ticket was mentioned in Slack in #core-themes by poena. View the logs.


5 months ago

#6 @poena
4 months ago

Hi
I have tested the GitHub PR and the two patches.

I recommend merging https://core.trac.wordpress.org/attachment/ticket/61951/61591.diff
Because out of the three suggested changes, it is the most consistent with the spacing and naming. In this patch the pattern slug and pattern file name includes the word "hidden": hidden-posts-heading. This is consistent with the other hidden patterns in the themes.

The text displays correctly without issues in the Site Editor and on the front.
To test the index template in Twenty Twenty-Four, I first deleted the home template.

#7 @poena
4 months ago

  • Keywords commit added; needs-testing removed

#8 @peterwilsoncc
4 months ago

  • Owner set to poena
  • Status changed from new to assigned

Assigning this to @poena as I think it would be a good first commit

#9 @poena
4 months ago

  • Resolution set to fixed
  • Status changed from assigned to closed

In 59065:

Bundled Themes: Make text strings translatable.

This changeset updates Twenty Twenty-Three and Twenty Twenty-Four and replaces text strings in HTML files with patterns to make the strings translatable.

Follow-up to [58459].

Props sabernhardt, karmatosed, iflairwebtechnologies, poena.
Fixes #61951.

Note: See TracTickets for help on using tickets.