Opened 5 months ago
Closed 4 months ago
#61951 closed defect (bug) (fixed)
TT3 and TT4: make template heading text translatable
Reported by: | sabernhardt | Owned by: | poena |
---|---|---|---|
Milestone: | 6.7 | Priority: | normal |
Severity: | normal | Version: | |
Component: | Bundled Theme | Keywords: | has-patch commit |
Focuses: | Cc: |
Description (last modified by )
Follow-up to #60298
Twenty Twenty-Three still has an untranslatable heading "Mindblown: a blog about philosophy." in home.html
.
Twenty Twenty-Four has "Posts" in its index.html
template.
Attachments (2)
Change History (11)
This ticket was mentioned in PR #7269 on WordPress/wordpress-develop by @iflairwebtechnologies.
5 months ago
#1
#3
@
5 months ago
- Keywords commit added
- Milestone changed from Awaiting Review to 6.7
I am going to pick the first patch as the second @iflairwebtechnologies seems to also have additional files in it. Thank you for both patches though. I am going to test and look to committing this.
#4
@
5 months ago
- Keywords needs-testing added; commit removed
For now, because this adds templates even though hidden, I think having more testing might be good so removing commit and adding testing. I will keep the milestone.
This ticket was mentioned in Slack in #core-themes by poena. View the logs.
5 months ago
#6
@
4 months ago
Hi
I have tested the GitHub PR and the two patches.
I recommend merging https://core.trac.wordpress.org/attachment/ticket/61951/61591.diff
Because out of the three suggested changes, it is the most consistent with the spacing and naming. In this patch the pattern slug and pattern file name includes the word "hidden": hidden-posts-heading
. This is consistent with the other hidden patterns in the themes.
The text displays correctly without issues in the Site Editor and on the front.
To test the index template in Twenty Twenty-Four, I first deleted the home template.
creating hidden templates for the headings so they can use PHP