Opened 3 months ago
Closed 11 days ago
#61963 closed defect (bug) (wontfix)
Twenty Twenty-One: defining standard `appearance` property in the CSS files
Reported by: | viralsampat | Owned by: | |
---|---|---|---|
Milestone: | Priority: | normal | |
Severity: | normal | Version: | |
Component: | Bundled Theme | Keywords: | has-patch reporter-feedback close 2nd-opinion |
Focuses: | css | Cc: |
Description
Hello Team,
I have reviewed twenty twenty-one theme and found CSS compatibility changes into the CSS file.
So, I think that it should be resolve it for consistency and standard.
Thanks,
Attachments (1)
Change History (4)
#1
@
3 months ago
- Keywords reporter-feedback added; dev-feedback has-testing-info removed
Hello @viralsampat,
The CSS files you've edited in the attached patch are generated from the files within the assets/sass
folder.
It appears that the rules you've altered all come from the external library, normalize.
/*! normalize.css v8.0.1 | MIT License | github.com/necolas/normalize.css */
The CSS rules from normalize are intentionally not cross-browser, as they exist purely to "normalize" the display in various browsers.
Is there a specific problem which you're attempting to resolve with this ticket? or is it purely formatting and consistency? If so, I believe this ticket is actually invalid
as normalize is intentional.
#2
@
3 months ago
- Keywords close 2nd-opinion added
- Summary changed from Twenty twenty-one theme: I have defined standard property into the CSS file. to Twenty Twenty-One: defining standard `appearance` property in the CSS files
The patch involves more than normalize.css
, but I would not recommend the proposed changes.
- The
button
and[type=search]
rulesets come from thenormalize.css
external library (which the theme has modified). The library mentions that those two rulesets are for "iOS and Safari" and for "Chrome and Safari". - The checkboxes and radio buttons and the range inputs have special styles within a
@supports (-webkit-appearance: none) or (-moz-appearance: none)
condition (PR 142). If some browser needsappearance: none
, and if no other browsers would have a problem with that rule, then it likely would belong in the feature query list with the prefixed properties. - The classic Search widget field styles target small iOS devices (PR 400).
#3
@
11 days ago
- Milestone Awaiting Review deleted
- Resolution set to wontfix
- Status changed from new to closed
I tend to agree with you @sabernhardt and thank you for the considerations.
@viralsampat whilst I appreciate your review in this case I am going to progress with the recommendation to close.
I have checked above mentioned issue and founds few files. Here, I have added its patch.