Make WordPress Core

Opened 7 months ago

Closed 6 months ago

Last modified 6 months ago

#61981 closed enhancement (fixed)

Proposal: track HEIC server support

Reported by: adamsilverstein's profile adamsilverstein Owned by: adamsilverstein's profile adamsilverstein
Milestone: 6.7 Priority: normal
Severity: normal Version:
Component: Upgrade/Install Keywords: has-patch commit
Focuses: Cc:

Description (last modified by adamsilverstein)

We recently landed support for converting HEIC images to JPEGs when uploading, solving a big issue for users who want to post images to their sites.

This feature requires requires that the server support HEIC in Imagick or possibly GD, the two image libraries used by WordPress to process images on the server side.

It would be nice to know what percentage of WordPress sites have HEIC support on the server since we are working on a parallel effort to move media processing to the client.

In #48116 we added checks for server support for WebP and AVIF formats for similar reasons, this ticket proposes adding HEIC support detection.

Change History (13)

This ticket was mentioned in PR #7288 on WordPress/wordpress-develop by @adamsilverstein.


7 months ago
#1

  • Keywords has-patch added

#2 @adamsilverstein
7 months ago

  • Owner set to adamsilverstein
  • Status changed from new to assigned
  • Type changed from defect (bug) to enhancement

@dd32 what do you think?

#3 @adamsilverstein
7 months ago

  • Description modified (diff)

#4 @dd32
7 months ago

Commented on the PR:

PR Approved. Works for me.

Note: I did consider suggesting just sending Imagick::queryFormats( '*' ) over (and the relevant version for GD), but looking at the output from those functions, there's so much in there.. let's just continue to report the relevant details for now.

Let's also keep it in mind to add it early when there's a suggestion of supporting a new format, not after the fact.

@adamsilverstein commented on PR #7288:


7 months ago
#5

Works for me.

Note: I did consider suggesting just sending Imagick::queryFormats( '*' ) over (and the relevant version for GD), but looking at the output from those functions, there's so much in there.. let's just continue to report the relevant details for now.

Let's also keep it in mind to add it early when there's a suggestion of supporting a new format, not after the fact.

Thanks for reviewing @dd32 and good point about adding early, will keep that in the mind if we try to land support for another format.

#6 @adamsilverstein
7 months ago

  • Keywords commit added
  • Milestone changed from Awaiting Review to 6.7

Marking for commit, not one small doc block correction on the PR that should be addressed with the commit.

#7 follow-up: @peterwilsoncc
6 months ago

@dd32 Does anything need to be done on the meta side before this can be committed?

#8 in reply to: ↑ 7 @dd32
6 months ago

Replying to peterwilsoncc:

@dd32 Does anything need to be done on the meta side before this can be committed?

Nope! No harm in sending extra data that the API isn't yet handling. That being said; I've already added support in the needed places for this (apologies for not following up on the ticket)

#9 @peterwilsoncc
6 months ago

  • Resolution set to fixed
  • Status changed from assigned to closed

In 59018:

Upgrade/Install: Indicate HEIC support when checking upgrades.

Adds tracking of HEIC image type support alongside WebP and AVID image types when requesting upgrade from WordPress.org

Props adamsilverstein, swissspidy, dd32, mukesh27.
Fixes #61981.

@peterwilsoncc commented on PR #7288:


6 months ago
#10

Merged r59018 / https://github.com/WordPress/wordpress-develop/commit/1730f7713f31674caab68607e01bb6d408ffa091

I pushed the comment fix and merged in trunk prior to committing.

#11 @samiamnot
6 months ago

Just a suggestion. Why not add server support tracking for JPEG XL at this point (early as suggested by @dd32) While the browsers may not be ready, it is moving forward quickly. See #52788.

#12 @samiamnot
6 months ago

One more note. The iPhone 16 (available on 9/20) supports JPEG XL. This will likely cause an increased focus on the format.

#13 @samiamnot
6 months ago

#62050 was created to track JPEG XL server support.

Note: See TracTickets for help on using tickets.