Changes between Initial Version and Version 1 of Ticket #61983, comment 2
- Timestamp:
- 09/09/2024 05:33:34 PM (17 months ago)
Legend:
- Unmodified
- Added
- Removed
- Modified
-
Ticket #61983, comment 2
initial v1 1 1 Thanks for the report and patch, @adamsilverstein 🙌🏻 2 2 3 Yeah, [https://github.com/WordPress/wordpress-develop/blob/fd6c5606b1c572442f0eb15bafee0852cbbb7035/tests/phpunit/tests/media/wpGenerateAttachmentMetadata.php wpGenerateAttachmentMetadata.php] doesn't cover that kind of scenario yet. What are the conditions required to validate the use of the fallback extension? When the attachment is a video, then `$metadata['image']['data']` isn't set, which skips that path.3 Yeah, [https://github.com/WordPress/wordpress-develop/blob/fd6c5606b1c572442f0eb15bafee0852cbbb7035/tests/phpunit/tests/media/wpGenerateAttachmentMetadata.php wpGenerateAttachmentMetadata.php] doesn't cover that kind of scenario yet. What are the conditions required to validate the use of the fallback extension? When the attachment is video/audio, then `$metadata['image']['data']` isn't set, which skips that path.