#61988 closed defect (bug) (fixed)
Error page viewport missing initial-scale=1
Reported by: | kkmuffme | Owned by: | SergeyBiryukov |
---|---|---|---|
Milestone: | 6.7 | Priority: | normal |
Severity: | trivial | Version: | |
Component: | General | Keywords: | has-patch |
Focuses: | Cc: |
Description
https://github.com/WordPress/wordpress-develop/blob/trunk/src/wp-includes/functions.php#L3871
The viewport meta should inclue initial-scale=1.0 to ensure high DPI/mobile display works as expected.
See why here:
https://css-tricks.com/probably-use-initial-scale1/
https://www.sitepoint.com/community/t/is-it-necessary-to-include-initial-scale-1-0-in-the-meta-viewport-tag/455119/2
Change History (16)
This ticket was mentioned in PR #7294 on WordPress/wordpress-develop by @narenin.
5 weeks ago
#1
- Keywords has-patch added
This ticket was mentioned in PR #7295 on WordPress/wordpress-develop by @kkmuffme.
5 weeks ago
#2
add initial-scale=1.0
Trac ticket: https://core.trac.wordpress.org/ticket/61988
@swissspidy commented on PR #7295:
5 weeks ago
#3
De-duping with #7294 which was created first
#4
@
5 weeks ago
- Milestone changed from Awaiting Review to 6.7
Looks reasonable, thanks for the ticket & PR!
#5
@
5 weeks ago
Thanks for the ticket! Should this also be added in a few other places where it's currently missing?
#7
in reply to:
↑ 6
@
5 weeks ago
Replying to mukesh27:
Some of the default themes also missing
Indeed, from Twenty Eleven to Twenty Fifteen.
@kkmuffme commented on PR #7295:
5 weeks ago
#9
@swissspidy please reopen, and close the other one, bc the other one is wrong. It expects a float 1.0 according to docs, not 1 (besides the fact I'm the OP of the trac ticket)
#10
@
4 weeks ago
The wp-includes
directory has another viewport
tag in wp-includes/functions.php (added in [32501]).
It expects a float 1.0 according to docs, not 1
I did not find a requirement to include the decimal, though it may be preferable.
- W3C's current draft does not mention values.
- W3C's 2016 draft shows the values
1
,0.1
,1.0
,2.0
, and10
. - MDN web docs mentions the default
1
, minimum0.1
, and maximum10
. - Both Safari Web Content Guide and Chrome for Developers suggest
1.0
. - Android Developers is the only resource I found that mentions "float" (in
float_value
), and its example uses1.0
. - CSS Tricks recommends
1
, and one of the commenters says that there is no difference between1.0
and1
.
This ticket was mentioned in PR #7327 on WordPress/wordpress-develop by @dhruvang21.
4 weeks ago
#11
#14
@
3 weeks ago
- Owner set to SergeyBiryukov
- Resolution set to fixed
- Status changed from new to closed
In 59027:
@SergeyBiryukov commented on PR #7294:
3 weeks ago
#15
Thanks for the PR! Merged in r59027.
Trac ticket: https://core.trac.wordpress.org/ticket/61988