Make WordPress Core

Opened 5 weeks ago

Closed 3 weeks ago

Last modified 3 weeks ago

#61988 closed defect (bug) (fixed)

Error page viewport missing initial-scale=1

Reported by: kkmuffme's profile kkmuffme Owned by: sergeybiryukov's profile SergeyBiryukov
Milestone: 6.7 Priority: normal
Severity: trivial Version:
Component: General Keywords: has-patch
Focuses: Cc:

Change History (16)

This ticket was mentioned in PR #7294 on WordPress/wordpress-develop by @narenin.


5 weeks ago
#1

  • Keywords has-patch added

This ticket was mentioned in PR #7295 on WordPress/wordpress-develop by @kkmuffme.


5 weeks ago
#2

add initial-scale=1.0

Trac ticket: https://core.trac.wordpress.org/ticket/61988

@swissspidy commented on PR #7295:


5 weeks ago
#3

De-duping with #7294 which was created first

#4 @swissspidy
5 weeks ago

  • Milestone changed from Awaiting Review to 6.7

Looks reasonable, thanks for the ticket & PR!

#5 @SergeyBiryukov
5 weeks ago

Thanks for the ticket! Should this also be added in a few other places where it's currently missing?

#6 follow-up: @mukesh27
5 weeks ago

Some of the default themes also missing

#7 in reply to: ↑ 6 @SergeyBiryukov
5 weeks ago

Replying to mukesh27:

Some of the default themes also missing

Indeed, from Twenty Eleven to Twenty Fifteen.

#8 @sabernhardt
5 weeks ago

I gave the bundled themes changes a separate ticket: #61993.

@kkmuffme commented on PR #7295:


5 weeks ago
#9

@swissspidy please reopen, and close the other one, bc the other one is wrong. It expects a float 1.0 according to docs, not 1 (besides the fact I'm the OP of the trac ticket)

#10 @sabernhardt
4 weeks ago

The wp-includes directory has another viewport tag in wp-includes/functions.php (added in [32501]).


It expects a float 1.0 according to docs, not 1

I did not find a requirement to include the decimal, though it may be preferable.

Last edited 4 weeks ago by sabernhardt (previous) (diff)

This ticket was mentioned in PR #7327 on WordPress/wordpress-develop by @dhruvang21.


4 weeks ago
#11

#12 @sabernhardt
4 weeks ago

#61993 was marked as a duplicate.

#13 @SergeyBiryukov
3 weeks ago

In 59026:

Bundled Themes: Add missing initial-scale value in viewport meta tag.

The viewport meta should include initial-scale=1.0 to ensure that high DPI/mobile display works as expected.

Includes standardizing on 1.0 vs. 1 for consistency.

References:

Props dhruvang21, sabernhardt, kkmuffme, mukesh27, swissspidy, SergeyBiryukov.
See #61988.

#14 @SergeyBiryukov
3 weeks ago

  • Owner set to SergeyBiryukov
  • Resolution set to fixed
  • Status changed from new to closed

In 59027:

General: Add missing initial-scale value in viewport meta tags.

The viewport meta should include initial-scale=1.0 to ensure that high DPI/mobile display works as expected.

References:

Follow-up to [59026].

Props dhruvang21, sabernhardt, kkmuffme, mukesh27, narenin, swissspidy, SergeyBiryukov.
Fixes #61988.

@SergeyBiryukov commented on PR #7294:


3 weeks ago
#15

Thanks for the PR! Merged in r59027.

@SergeyBiryukov commented on PR #7327:


3 weeks ago
#16

Thanks for the PR! Merged in r59026 and 59027.

Note: See TracTickets for help on using tickets.