#61993 closed defect (bug) (duplicate)
Bundled themes: add initial-scale to viewport meta
Reported by: | mukesh27 | Owned by: | |
---|---|---|---|
Milestone: | Priority: | normal | |
Severity: | normal | Version: | |
Component: | Bundled Theme | Keywords: | has-patch |
Focuses: | Cc: |
Description
Related: #61988
The viewport meta tags for themes from Twenty Eleven to Twenty Fifteen do not set the initial-scale
value.
Attachments (2)
Change History (10)
#1
@
2 months ago
I used 1
for consistency with most of the other themes. Twenty Twenty uses 1.0
, which I kept, but I wanted to remove the extra space.
Additional props from #61988: SergeyBiryukov
#2
@
2 months ago
In case the value of 1.0
is preferred, I uploaded a patch to update existing tags to that value, too.
#3
@
2 months ago
Hi @sabernhardt,
I’ve applied your patch to add the initial scale in the viewport across all themes. Additionally, I’ve implemented the changes in the core file as mentioned by @SergeyBiryukov in the core ticket: #61988.
Would it be appropriate to include the core file changes in this PR, or should they be handled in a separate PR related to the ticket #61988?
This ticket was mentioned in PR #7327 on WordPress/wordpress-develop by @dhruvang21.
2 months ago
#4
#5
@
2 months ago
I prefer to have separate commits for editing theme files, but it is not imperative. If I write the theme changelog updates, I am already aware of the general ticket #61988.
If you want everything in one pull request:
- You could update the Trac link in your PR summary to point to the first ticket instead.
- The
_default_wp_die_handler()
function has anotherviewport
tag in wp-includes/functions.php that could includeinitial-scale
.
Adds
initial-scale=1
for Twenty Eleven to Twenty Fifteen, removes space in Twenty Twenty's viewport meta tag