Make WordPress Core

Opened 3 months ago

Closed 3 months ago

Last modified 3 months ago

#61993 closed defect (bug) (duplicate)

Bundled themes: add initial-scale to viewport meta

Reported by: mukesh27's profile mukesh27 Owned by:
Milestone: Priority: normal
Severity: normal Version:
Component: Bundled Theme Keywords: has-patch
Focuses: Cc:

Description

Related: #61988

The viewport meta tags for themes from Twenty Eleven to Twenty Fifteen do not set the initial-scale value.

Attachments (2)

61993.diff (3.8 KB) - added by sabernhardt 3 months ago.
Adds initial-scale=1 for Twenty Eleven to Twenty Fifteen, removes space in Twenty Twenty's viewport meta tag
61993.1.0.diff (6.3 KB) - added by sabernhardt 3 months ago.
uses 1.0 instead of 1 for each viewport meta tag

Download all attachments as: .zip

Change History (10)

@sabernhardt
3 months ago

Adds initial-scale=1 for Twenty Eleven to Twenty Fifteen, removes space in Twenty Twenty's viewport meta tag

#1 @sabernhardt
3 months ago

I used 1 for consistency with most of the other themes. Twenty Twenty uses 1.0, which I kept, but I wanted to remove the extra space.

Additional props from #61988: kkmuffme, SergeyBiryukov

Last edited 3 months ago by sabernhardt (previous) (diff)

@sabernhardt
3 months ago

uses 1.0 instead of 1 for each viewport meta tag

#2 @sabernhardt
3 months ago

In case the value of 1.0 is preferred, I uploaded a patch to update existing tags to that value, too.

#3 @dhruvang21
3 months ago

Hi @sabernhardt,

I’ve applied your patch to add the initial scale in the viewport across all themes. Additionally, I’ve implemented the changes in the core file as mentioned by @SergeyBiryukov in the core ticket: #61988.

Would it be appropriate to include the core file changes in this PR, or should they be handled in a separate PR related to the ticket #61988?

Last edited 3 months ago by SergeyBiryukov (previous) (diff)

This ticket was mentioned in PR #7327 on WordPress/wordpress-develop by @dhruvang21.


3 months ago
#4

#5 @sabernhardt
3 months ago

I prefer to have separate commits for editing theme files, but it is not imperative. If I write the theme changelog updates, I am already aware of the general ticket #61988.

If you want everything in one pull request:

  1. You could update the Trac link in your PR summary to point to the first ticket instead.
  2. The _default_wp_die_handler() function has another viewport tag in wp-includes/functions.php that could include initial-scale.
Last edited 3 months ago by sabernhardt (previous) (diff)

#6 @dhruvang21
3 months ago

Updated the track link in the PR Summary and added initial-scale in the viewport.

#7 @sabernhardt
3 months ago

  • Milestone 6.7 deleted
  • Resolution set to duplicate
  • Status changed from new to closed

Duplicate of #61988.

Thanks! I'll close this ticket as a duplicate then.

@SergeyBiryukov commented on PR #7327:


3 months ago
#8

Thanks for the PR! Merged in r59026 and 59027.

Note: See TracTickets for help on using tickets.