WordPress.org
Get WordPress

Make WordPress Core

Opened 10 months ago

Closed 6 months ago

Last modified 6 months ago

#62009 closed defect (bug) (fixed)

use strict comparison in wp-admin/includes/media.php

Reported by: deepakrohilla's profile deepakrohilla Owned by: sergeybiryukov's profile SergeyBiryukov
Milestone: 6.8 Priority: normal
Severity: normal Version:
Component: General Keywords: has-patch
Focuses: Cc:

Description

use strict comparison

Attachments (2)

use-scrict.JPG​ (42.9 KB) - added by deepakrohilla 10 months ago.
62009.patch​ (549 bytes) - added by iflairwebtechnologies 9 months ago.
Added strict comparison in wp-admin/includes/media.php

Download all attachments as: .zip

Change History (11)

@deepakrohilla
10 months ago

​@dingguodong commented on ​PR #7309:
10 months ago #2

Oh, it's very confusing. I wander that why there is only one change in the file but there are 27 commits?

​@mukesh27 commented on ​PR #7309:
9 months ago #3

@DingGuodong, this is due to code committed in the branch and some upstream merges. Only the new changes need to be reviewed. When you have a moment, please review them and share your feedback here.

​@dingguodong commented on ​PR #7309:
9 months ago #4

@DingGuodong, this is due to code committed in the branch and some upstream merges. Only the new changes need to be reviewed. When you have a moment, please review them and share your feedback here.

Thanks for your reply. So, I think it is due to the committer pull some commits from another branch before request this PR.

@iflairwebtechnologies
9 months ago

Added strict comparison in wp-admin/includes/media.php

​@mukesh27 commented on ​PR #7339:
9 months ago #6

Closing in favor of #7309

#7 @SergeyBiryukov
6 months ago

  • Owner set to SergeyBiryukov
  • Resolution set to fixed
  • Status changed from new to closed

In 59497:

Coding Standards: Use strict comparison in media_upload_form_handler().

Follow-up to [10390].

Props deepakrohilla, iflairwebtechnologies, mukesh27, dingguodong, aristath.
Fixes #62009.

#8 @SergeyBiryukov
6 months ago

  • Milestone changed from Awaiting Review to 6.8

​@SergeyBiryukov commented on ​PR #7309:
6 months ago #9

Thanks for the PR! Merged in r59497.

Note: See TracTickets for help on using tickets.