Opened 2 years ago
Last modified 2 weeks ago
#62010 reopened defect (bug)
Twenty Twelve: fix heading typography in the editor
| Reported by: | dilip2615 | Owned by: | |
|---|---|---|---|
| Priority: | normal | Milestone: | Future Release |
| Component: | Bundled Theme | Version: | |
| Severity: | normal | Keywords: | has-patch has-screenshots good-first-bug |
| Cc: | Focuses: | css |
Description
When activating the 'Twenty Twelve' theme and creating any post then display 'Add title' font size is very low compare to others
Attachments (6)
Change History (22)
#1
@
2 years ago
i'm new to core; i tried finding the file where the code for 'add new post' is written, but couldn't make it.
I want to contribute to this ticket, could anyone pl help me finding the related file?
@
2 years ago
adds selectors with .editor-styles-wrapper and/or .wp-block-post-title for typography rulesets
#2
@
2 years ago
- Component General → Bundled Theme
- Keywords needs-design removed
- Version 6.6.1
The post title font-size should remain as it is on the front: the rem equivalent of 20px for small screens, 22px for screens wider than 600 pixels. It is very late to change that in a 12-year-old theme.
In the (iframe) editor, the size equals 21 pixels, which is a minor mismatch. However, the editor-blocks.css file had defined styles to match the front with now-obsolete selectors such as .editor-post-title__block .editor-post-title__input. The font-weight is a more noticeable difference than the size.
The patch adds selectors that fit the current editor. Some of the proposed updates are not necessary within the iframe, but the non-framed version would use them. I also kept the original selectors for anyone with a WordPress 5.x site.
This ticket was mentioned in PR #7319 on WordPress/wordpress-develop by @iflairwebtechnologies.
2 years ago
#3
#4
@
2 years ago
@dilip2615
Generated new 62010.patch
Here you can see beforUpdated.png and afterUpdate.png
#5
@
2 years ago
- Milestone Awaiting Review → Future Release
- Summary Twenty Twelve: Add title size is very low. → Twenty Twelve: fix heading typography in the editor
I could have edited the ticket summary earlier. The theme's font size for post titles is 20px with narrower viewports and 22px for wider. 62010.diff may need additional iterations, but the patch should follow that direction.
#6
follow-up:
↓ 7
@
2 years ago
- Keywords needs-refresh good-first-bug added
Nice catch @dilip2615
As patch needs some iteration i'm going to add the needs-refresh, also added good-first-bug
This ticket was mentioned in PR #7701 on WordPress/wordpress-develop by @anujrathore24.
23 months ago
#8
- Keywords needs-refresh removed
## PR Description
- Fix Heading Typography for Theme twenty twelve, for different viewports.
- Post titles are now set to 20px for narrow viewports and 22px for wider viewports, consistent with frontend design. Editor styles have been updated to reflect these sizes, providing a cohesive editing experience.
Trac ticket: https://core.trac.wordpress.org/ticket/62010
---
#9
@
23 months ago
Hello @sabernhardt,
Can you please review my PR and let me know if there are any changes required.
Thank You!
@dilip2615 commented on PR #7319:
23 months ago
#10
Please review it.
@Hemant Ahir commented on PR #7319:
23 months ago
#11
I've reviewed it, and everything is working fine on my end
#12
@
19 months ago
- Resolution → reported-upstream
- Status new → closed
Hello @dilip2615
Please Increase the font-sze in h1 like, font-size: 1.5rem; to font-size: 2.5rem;
=> file Directory Path wp-content/themes/twentytwelve/editor-style.css
This ticket was mentioned in Slack in #meta by logicrays. View the logs.
19 months ago
#14
follow-up:
↓ 15
@
19 months ago
- Resolution reported-upstream
- Status closed → reopened
It looks like this one was closed on accident. Reopening so it can be tested and properly considered.
#15
in reply to: ↑ 14
@
19 months ago
Replying to desrosj:
It looks like this one was closed on accident. Reopening so it can be tested and properly considered.
Hello @desrosj got it your points and thanks for your suggestion.
this ticket is review from our side and get the solution but how can I submit my answer for this ticket actually I don't know.
already review the #meta doc but I miss some point from my side.So Can you tell me how can I submit my solution for this ticket.
#16
@
2 weeks ago
Tested 62010.diff locally with Twenty Twelve.
I created a post with H1 to H6, checked the editor before applying the patch, then applied the changes to css/editor-blocks.css and tested again.
What I found:
- Post title is 22px at 600px and above.
- Post title is 20px at 500px.
- H1 is 21px.
- The updated selectors are working in the editor.
- Front-end typography did not change.
Patch works as expected on my setup.
Screenshots:
- Editor after patch: https://i.imgur.com/TyeJECi.png
- Front end after patch: https://i.imgur.com/qc6KLw2.png
- Desktop title at 22px: https://i.imgur.com/RXyJVy5.png
- 500px title at 20px: https://i.imgur.com/S66esSm.png
![(please configure the [header_logo] section in trac.ini)](/chrome/site/your_project_logo.png)
Add title display very low, need to increase/improve font size.