#62022 closed defect (bug) (fixed)
Missing PHPDoc tag for WP_Query::$query_vars_changed
Reported by: | marian1 | Owned by: | SergeyBiryukov |
---|---|---|---|
Milestone: | 6.8 | Priority: | normal |
Severity: | trivial | Version: | |
Component: | Query | Keywords: | has-patch |
Focuses: | docs | Cc: |
Description
@var bool $query_vars_changed
is missing for the property $query_vars_changed
of class WP_Query
.
<?php /** * Whether query vars have changed since the initial parse_query() call. Used to catch modifications to query vars made * via pre_get_posts hooks. * * @since 3.1.1 */ private $query_vars_changed = true;
Lines 440-446 in wp-includes/class-wp-query.php
Attachments (1)
Change History (9)
This ticket was mentioned in PR #7318 on WordPress/wordpress-develop by PARTHVATALIYA.
4 months ago
#2
@martin.krcho commented on PR #7318:
4 months ago
#3
PARTHVATALIYA commented on PR #7318:
4 months ago
#4
Thank you for pointing that out. The changes to the structure of the if
statements in the WP_Query::parse_search()
function were unintentional and made by mistake. We will revert those changes and handle them in a separate commit if needed in the future.
I'm closing this PR, and I'll submit a new one with the intended changes. Thanks again for the review!
This ticket was mentioned in PR #7320 on WordPress/wordpress-develop by PARTHVATALIYA.
4 months ago
#5
#6
@
7 weeks ago
- Owner set to SergeyBiryukov
- Resolution set to fixed
- Status changed from new to closed
In 59495:
@SergeyBiryukov commented on PR #7320:
7 weeks ago
#8
Thanks for the PR! Merged in r59495.
@PARTHVATALIYA your commit changes the structure of
if
statements inWP_Query::parse_search()
function. Is that intentional? The logic didn't change as far as I can tell, but it would be a good idea to do such changes in a separate commit.