Make WordPress Core

Changes between Initial Version and Version 1 of Ticket #62035, comment 5


Ignore:
Timestamp:
09/12/2024 08:01:15 PM (8 weeks ago)
Author:
SergeyBiryukov
Comment:

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #62035, comment 5

    initial v1  
    22> Mind taking a look @SergeyBiryukov ?
    33
    4 Thanks for the ping! I saw the ticket, but I can't figure out how to reproduce this yet. `$this->id` should only ever be an `int`as noted in comment:1::
     4Thanks for the ping! I saw the ticket, but I can't figure out how to reproduce this yet. `$this->id` should only ever be an `int`, as noted in comment:1::
    55> [https://github.com/WordPress/wordpress-develop/blob/a8d12183f23694718756c9e84338e12342b2fcb9/src/wp-includes/class-wp-network.php#L31-L33 Since version 4.6], the network ID has been an `int`, and enforced as such by the [https://github.com/WordPress/wordpress-develop/blob/a8d12183f23694718756c9e84338e12342b2fcb9/src/wp-includes/class-wp-network.php#L153-L154 getter]/[https://github.com/WordPress/wordpress-develop/blob/a8d12183f23694718756c9e84338e12342b2fcb9/src/wp-includes/class-wp-network.php#L197-L199 setter]. In the updated code, `$this->id` shouldn't be a string ([https://github.com/WordPress/wordpress-develop/blob/a8d12183f23694718756c9e84338e12342b2fcb9/src/wp-includes/class-wp-network.php#L65 compared with] `$this->blog_id` which is still a string for backward compat).