WordPress.org
Get WordPress

Make WordPress Core

Changes between Initial Version and Version 5 of Ticket #62070


Ignore:
Timestamp:
10/05/2024 05:48:10 PM (23 months ago)
Author:
sabernhardt
Comment:

Is switching from null to an empty string good, or should it not print the hidden fields with an empty attribute if the success or reject URL is not defined?

Legend:

Unmodified
Added
Removed
Modified

  • Ticket #62070

    • Property Keywords php-81 has-patch added
    • Property Focuses php-compatibility removed
    • Property Component General → Application Passwords
    • Property Summary PHP 8.1 PHP Deprecated: trim(): Passing null to parameter #1 ($string) of type string is deprecated → PHP Deprecated warnings with null values for success and reject URLs
    • Property Version → 5.6

  • Ticket #62070 – Description

    initial v5  
    1 PHP Deprecated:  ltrim(): Passing null to parameter #1 ($string) of type string is deprecated in /var/www/src/wp-includes/formatting.php on line 4482
     1If the `$success_url` or `$reject_url` are set to `null`, then running `esc_url()` on those for [https://github.com/WordPress/wordpress-develop/blob/c4752a11cfc53a49b63d4b786bac9fe62eba1604/src/wp-admin/authorize-application.php#L243-L244 hidden inputs] could produce PHP warnings.
     2
     3`PHP Deprecated:  ltrim(): Passing null to parameter #1 ($string) of type string is deprecated in /.../wp-includes/formatting.php on line 4482`