WordPress.org
Get WordPress

Make WordPress Core

Opened 23 months ago

Closed 23 months ago

Last modified 23 months ago

#62076 closed task (blessed) (fixed)

Composer: update to PHP_CodeSniffer 3.10.3

Reported by: jrf Owned by: SergeyBiryukov
Priority: normal Milestone: 6.7
Component: Build/Test Tools Version:
Severity: normal Keywords: add-to-field-guide has-patch
Cc: Focuses: coding-standards

Description

PHPCS has seen seven new releases since the last update, which means more bugs have been fixes, syntax support for PHP 8.3 was added, more sniff documentation is available, performance improvements and a fancy new Help screen etc.

I recommend updating the version used by WordPress to benefit from these changes.

Refs:

Previous: #59161, #60279

Change History (6)

This ticket was mentioned in ​PR #7398 on ​WordPress/wordpress-develop by ​@jrf.
23 months ago #1

  • Keywords has-patch added

There have been numerous new PHPCS releases since 3.9.0. Let's take advantage of the bug fixes made ;-)

Trac ticket: https://core.trac.wordpress.org/ticket/62076

#2 @SergeyBiryukov
23 months ago

  • Owner set to SergeyBiryukov
  • Status new → accepted

#3 @SergeyBiryukov
23 months ago

In 59066:

Coding Standards: Remove unused return value for WP_Object_Cache::__set().

This resolves a WPCS warning:

Assignments must be the first block of code on a line

Note: This is enforced by PHPCS 3.10.3.

Follow-up to [28521], [29146].

Props jrf.
See #62076, #61607.

#4 @SergeyBiryukov
23 months ago

  • Resolution → fixed
  • Status accepted → closed

In 59067:

Coding Standards: Update PHPCS to version 3.10.3.

PHPCS has seen several new releases since the last update, which means more bugs have been fixed, syntax support for PHP 8.3 was added, more sniff documentation is available, performance improvements, a new Help screen, etc.

References:

Follow-up to [56695], [56799], [57378], [57986].

Props jrf.
Fixes #62076.

​@SergeyBiryukov commented on ​PR #7398:
23 months ago #5

Thanks for the PR! Merged in r59067.

​@jrf commented on ​PR #7398:
23 months ago #6

Thanks @sergeyBiryukov!

Note: See TracTickets for help on using tickets.