Twenty Fifteen : PHPCS Fixes

[pitamdey]

In theme Twenty-Fifteen, I can see there are a few PHPCS errors, so I have applied an patch to fix it.

[pitamdey]

Patch for this issue

[sabernhardt]

The patch proposes many changes:

• adds a param note in the twentyfifteen_excerpt_more() docblock
• escapes 21 translations
• escapes number_format_i18n() in the comments template
• escapes $GLOBALS['wp_version'] in back-compat.php functions
• escapes multiple items in twentyfifteen_entry_meta()
  1. get_post_format_string(), which returns a translation
  2. $categories_list and $tags_list (TT1 does not escape taxonomy lists)
  3. width and height for the full size attachment link (TT1 uses absint() in its image template)

I do not recommend all the escaping for (only) this theme.

Core translations are trusted (ticket:58127#comment:1), and #30724 specifically removed escaping functions for Twenty Fifteen's translations. If that policy ever changes for bundled themes before Twenty Twenty-One, that effort could have one ticket for all the themes.

For future reference, note that _e() would need to be replaced with esc_html_e(), not esc_html__() (404.php template).

The twentyfifteen_excerpt_more() function should document the $more parameter, and I like the similar description in Twenty Fourteen and Twenty Thirteen:

	 * @param string $more Default Read More excerpt link.

[sabernhardt]

adds only the param documentation for twentyfifteen_excerpt_more()

[SergeyBiryukov]

Hi there, thanks for the ticket!

It appears that while the other changes could use some more discussion, 62079.docs.patch​ is ready for commit.

[SergeyBiryukov]

In 59110:

Twenty Fifteen: Document the $more parameter in twentyfifteen_excerpt_more().

Follow-up to [30237], [30569].

Props pitamdey, sabernhardt.
See #62079.

[SergeyBiryukov]

Moving back to Awaiting Review for the other changes here, as per comment:1.