Make WordPress Core

Opened 6 months ago

Closed 6 months ago

Last modified 6 months ago

#62081 closed defect (bug) (fixed)

Block editor and Customizer display avatars even when 'show_avatars' option is disabled

Reported by: ffffelix's profile ffffelix Owned by: sergeybiryukov's profile SergeyBiryukov
Milestone: 6.7 Priority: normal
Severity: normal Version:
Component: Editor Keywords: has-patch
Focuses: Cc:

Description

In two instances, avatars are displayed even when the site option show_avatars is disabled.

  • Block editor: the avatar is passed in to $editor_settings on initial load by edit-form-blocks.php
  • Customizer: outputs the avatar via WP_Customize_Manager->get_lock_user_data()

This is already handled correctly in the classic editor and in the Heartbeat AJAX handler for refreshing the post lock.

Attachments (4)

post-before.png (133.8 KB) - added by ffffelix 6 months ago.
Block editor with show_avatars disabled (before patch)
post-after.png (128.6 KB) - added by ffffelix 6 months ago.
Block editor with show_avatars disabled (with patch)
customizer-before.png (81.1 KB) - added by ffffelix 6 months ago.
Customizer with show_avatars disabled (before patch)
customizer-after.png (76.1 KB) - added by ffffelix 6 months ago.
Customizer with show_avatars disabled (with patch)

Download all attachments as: .zip

Change History (8)

This ticket was mentioned in PR #7400 on WordPress/wordpress-develop by @ffffelix.


6 months ago
#1

  • Keywords has-patch added

Adds checks for the show_avatars option before setting the avatar for post lock modals in the block editor and the Customizer.

Trac ticket: https://core.trac.wordpress.org/ticket/62081

@ffffelix
6 months ago

Block editor with show_avatars disabled (before patch)

@ffffelix
6 months ago

Block editor with show_avatars disabled (with patch)

@ffffelix
6 months ago

Customizer with show_avatars disabled (before patch)

@ffffelix
6 months ago

Customizer with show_avatars disabled (with patch)

#2 @SergeyBiryukov
6 months ago

  • Owner set to SergeyBiryukov
  • Resolution set to fixed
  • Status changed from new to closed

In 59078:

Editor: Respect show_avatars option in block editor and Customizer.

This adds checks for the show_avatars option before setting the avatar for post lock modals in the block editor and the Customizer.

Follow-up to [41839], [53070].

Props ffffelix.
Fixes #62081.

#3 @SergeyBiryukov
6 months ago

  • Milestone changed from Awaiting Review to 6.7

@SergeyBiryukov commented on PR #7400:


6 months ago
#4

Thanks for the PR! Merged in r59078.

Note: See TracTickets for help on using tickets.