Make WordPress Core

Opened 16 years ago

Closed 16 years ago

#6209 closed defect (bug) (fixed)

Adding a category crashes the editor

Reported by: denis-de-bernardy's profile Denis-de-Bernardy Owned by: mdawaffe's profile mdawaffe
Milestone: 2.5 Priority: highest omg bbq
Severity: blocker Version: 2.5
Component: Administration Keywords: js has-patch needs-testing
Focuses: Cc:

Description (last modified by lloydbudd)

Procedure to reproduce using Camino on a Mac:

  1. Create a post, assign it the "test" tag
  2. Publish the post
  3. Edit the post, assign it a newly created "Test" category
  4. The save button no longer responds
  5. Upon browsing back to the editor, the category "test" (lowercase) got created but isn't assigned to the post

I more or less recall noticing a similar bug in WP 2.3, using FF on Windows. It likely applies to FF on Linux and to IE as well, since a workflow issue is arguably underneath.

Attachments (3)

6209.diff (6.7 KB) - added by mdawaffe 16 years ago.
6209.b.diff (7.2 KB) - added by mdawaffe 16 years ago.
Now with cache busting
6209.c.diff (829 bytes) - added by mdawaffe 16 years ago.

Download all attachments as: .zip

Change History (17)

#1 @lloydbudd
16 years ago

  • Component changed from Administration to TinyMCE
  • Description modified (diff)
  • Priority changed from normal to high

Denis-de-Bernardy, please, please include the version / subversion revision you are using. Thank you!

#2 follow-up: @Denis-de-Bernardy
16 years ago

Sorry about that! I was assuming that, upon selecting version 2.5, the fact I was testing trunk was obvious. ;-)

It's still occurring this morning by the way (rev 7283).

#3 @sambauers
16 years ago

Confirmed in [7290]

#4 in reply to: ↑ 2 @lloydbudd
16 years ago

Replying to Denis-de-Bernardy:

Sorry about that! I was assuming that, upon selecting version 2.5, the fact I was testing trunk was obvious. ;-)

Trunk is a rapidly moving target, including the revision is always desirable.

#5 @fergbrain
16 years ago

I can confirm this error occurs with FF 2.0.0.11 on Windows Server 2K3 and WP build 7326. My gut says that it may be an issue related to how the form tag is nested, or perhaps JS?

#6 @MtDewVirus
16 years ago

Tested with r7379 on FF2 and Safari 3.1...

If you write a new post and add it to a new category, the Save and Publish buttons do not respond. Similarly if you write a new link and add a new category to it, the Save button does not respond.

#7 @lloydbudd
16 years ago

  • Priority changed from high to highest omg bbq
  • Severity changed from major to blocker

#8 @MichaelH
16 years ago

Can confirm this happens with 2.5-RC1 with "use the visual editor when writing" checked and with this browser:
Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8.1.12) Gecko/20080201 Firefox/2.0.0.12

#9 @mdawaffe
16 years ago

  • Owner changed from anonymous to mdawaffe
  • Status changed from new to assigned

This may have been caused by [7262]. Investigating now.

#10 @mdawaffe
16 years ago

  • Component changed from TinyMCE to Administration
  • Keywords js added

6209.diff

Confirmed this was caused by over-aggressive form validation from [7262]. Attached makes form validation opt-in with .validate class.

@mdawaffe
16 years ago

#11 @mdawaffe
16 years ago

  • Keywords has-patch needs-testing added

@mdawaffe
16 years ago

Now with cache busting

#12 @ryan
16 years ago

  • Resolution set to fixed
  • Status changed from assigned to closed

(In [7384]) Fix over-aggressive form validation. Props mdawaffe. fixes #6209

#13 @mdawaffe
16 years ago

  • Resolution fixed deleted
  • Status changed from closed to reopened

6209.c.diff

Reverts wp-admin/edit-link-form.php. This form should not be run through the aggressive validator for the same reason the post form should not be.

@mdawaffe
16 years ago

#14 @ryan
16 years ago

  • Resolution set to fixed
  • Status changed from reopened to closed

(In [7385]) Fix over-aggressive form validation. Props mdawaffe. fixes #6209

Note: See TracTickets for help on using tickets.