Make WordPress Core

Opened 6 months ago

Closed 5 months ago

Last modified 5 months ago

#62096 closed defect (bug) (fixed)

Twenty Nineteen: adjust avatar dimensions for comment author

Reported by: sabernhardt's profile sabernhardt Owned by: karmatosed's profile karmatosed
Milestone: 6.7 Priority: normal
Severity: minor Version: 6.7
Component: Bundled Theme Keywords: has-patch commit
Focuses: css Cc:

Description

r58580 increased the size of avatars for the author of each comment (in the theme's template) from 49.5 pixels to 60. The image itself simply extends 10 pixels into the margin on larger screens now, but the author checkbox icon is positioned based on the earlier dimensions.

The 2.25rem dimensions could go in the comments SCSS file to restore them without affecting the avatar blocks.

Attachments (2)

before patch.png (53.7 KB) - added by nithins53 6 months ago.
after patch.png (49.4 KB) - added by nithins53 6 months ago.

Download all attachments as: .zip

Change History (10)

This ticket was mentioned in PR #7415 on WordPress/wordpress-develop by @sabernhardt.


6 months ago
#1

  • Keywords has-patch added
  • Restores 49.5 by 49.5 dimensions for comment author avatar next to each comment
  • Removes unnecessary auto dimensions
  • Does not assign dimensions for the images in Avatar, Author or Latest Comments blocks

Trac 62096

@sabernhardt commented on PR #7415:


6 months ago
#2

Before patch, the avatars are 60 by 60 pixels.

https://github.com/user-attachments/assets/316787b0-cffa-48be-a29e-ff77940e9192

With the patch, the avatars are 49.5 by 49.5.

https://github.com/user-attachments/assets/367f682a-068a-4aef-a7e5-da8dff0355c9

#3 @sabernhardt
6 months ago

  • Milestone changed from Awaiting Review to 6.7

#4 @nithins53
6 months ago

Tested the patch, works on my side.

#5 @sudipatel007
5 months ago

Test Report

Description
I have tested it with out patch in WP 6.7 and Avatars for the author of each comment is 60px

Environment

  • WordPress: 6.7-alpha-59082
  • PHP: 8.1.23
  • Server: nginx/1.16.0
  • Database: mysqli (Server: 8.0.16 / Client: mysqlnd 8.1.23)
  • Browser: Chrome 129.0.0.0 (macOS)
  • Theme: Twenty Nineteen 2.9
  • MU-Plugins:
    • Testing 10up's Ad Refresh Control Plugin

Screenshot
https://drive.google.com/file/d/1REzAUjH6sdzWLdTiZEheE6wDsV-J06T4/view?usp=sharing

#6 @karmatosed
5 months ago

  • Owner set to karmatosed
  • Resolution set to fixed
  • Status changed from new to closed

In 59222:

Twenty Nineteen: Fixes adjusting avatar dimensions for comment author.

In Twenty Nineteen r58580 increased size of avatars. This caused issues with the position of author checkbox. This resolves by moving without impacting the avatar blocks.

Props sabernhardt, nithins53, sudipatel007.
Fixes #62096.

#7 @karmatosed
5 months ago

  • Keywords commit added

I tested this and confirm the patch works so went through and pushed this to commit, thank you everyone.

@sabernhardt commented on PR #7415:


5 months ago
#8

Committed in r59222

Note: See TracTickets for help on using tickets.