Make WordPress Core

Opened 2 years ago

Closed 2 years ago

Last modified 2 years ago

#62112 closed defect (bug) (fixed)

Twenty Nineteen : PHPCS Fixes

Reported by: pitamdey Owned by: SergeyBiryukov
Priority: normal Milestone: 6.7
Component: Bundled Theme Version:
Severity: normal Keywords: has-patch
Cc: Focuses: docs, coding-standards

Description

In theme Twenty-Nineteen, I can see there are a few PHPCS errors, so I have applied a patch to fix them.

Attachments (3)

phpcs-fixes.patch​ (2.5 KB ) - added by pitamdey 2 years ago.
Patch for this issue
62112.patch​ (2.3 KB ) - added by viralsampat 2 years ago.
I have checked above mentioned issue and founds few files. Here, I have added its patch.
62112.2.patch​ (2.5 KB ) - added by viralsampat 2 years ago.
I have checked above mentioned issue and founds few files. Here, I have added its patch.

Download all attachments as: .zip

Change History (9)

@pitamdey
2 years ago

Patch for this issue

#1 @pitamdey
2 years ago

The PHPCS errors that were fixed are :

  • Doc comments are missing
  • The closing brace for the class must go on the next line after the body
  • There must be exactly one blank line after the file comment

#2 @SergeyBiryukov
2 years ago

  • Owner set to SergeyBiryukov
  • Resolution → fixed
  • Status new → closed

In 59090:

Twenty Nineteen: Add missing documentation for helper function parameters.

Follow-up to [43808], [44149], [47214], [47242].

Props pitamdey.
Fixes #62112.

#3 @SergeyBiryukov
2 years ago

  • Milestone Awaiting Review → 6.7

@viralsampat
2 years ago

I have checked above mentioned issue and founds few files. Here, I have added its patch.

#4 @SergeyBiryukov
2 years ago

In 59102:

Twenty Nineteen: Add more missing documentation for helper function parameters.

Follow-up to [59090].

Props viralsampat.
See #62112.

#5 @SergeyBiryukov
2 years ago

In 59103:

Twenty Nineteen: Remove trailing spaces in DocBlocks.

Follow-up to [59102].

Props mukesh27.
See #62112.

@viralsampat
2 years ago

I have checked above mentioned issue and founds few files. Here, I have added its patch.

#6 @sabernhardt
2 years ago

62112.2.patch proposes editing documentation in other themes, but those were already fixed last year (please update your files).

  • [56045] edited documentation for Twenty Twenty's filters.
  • [56118] documented the $current_screen and $is_IE variables in Twenty Twenty-One.
Note: See TracTickets for help on using tickets.