Make WordPress Core

Context Navigation

← Previous Ticket
Next Ticket →

Opened 22 months ago

Closed 22 months ago

Last modified 22 months ago

#62112 closed defect (bug) (fixed)

Twenty Nineteen : PHPCS Fixes

Reported by:	pitamdey	Owned by:	SergeyBiryukov
Priority:	normal	Milestone:	6.7
Component:	Bundled Theme	Version:
Severity:	normal	Keywords:	has-patch
Cc:		Focuses:	docs, coding-standards

Description

In theme Twenty-Nineteen, I can see there are a few PHPCS errors, so I have applied a patch to fix them.

Attachments (3)

phpcs-fixes.patch (2.5 KB ) - added by pitamdey 22 months ago.: Patch for this issue
62112.patch (2.3 KB ) - added by viralsampat 22 months ago.: I have checked above mentioned issue and founds few files. Here, I have added its patch.
62112.2.patch (2.5 KB ) - added by viralsampat 22 months ago.: I have checked above mentioned issue and founds few files. Here, I have added its patch.

Download all attachments as: .zip

Change History (9)

@pitamdey
22 months ago

Attachment phpcs-fixes.patch added

Patch for this issue

#1 @pitamdey
22 months ago

The PHPCS errors that were fixed are :

Doc comments are missing
The closing brace for the class must go on the next line after the body
There must be exactly one blank line after the file comment

#2 @SergeyBiryukov
22 months ago

Owner set to SergeyBiryukov
Resolution → fixed
Status new → closed

Twenty Nineteen: Add missing documentation for helper function parameters.

Follow-up to [43808], [44149], [47214], [47242].

Props pitamdey.
Fixes #62112.

#3 @SergeyBiryukov
22 months ago

Milestone Awaiting Review → 6.7

@viralsampat
22 months ago

Attachment 62112.patch added

I have checked above mentioned issue and founds few files. Here, I have added its patch.

#4 @SergeyBiryukov
22 months ago

Twenty Nineteen: Add more missing documentation for helper function parameters.

Follow-up to [59090].

Props viralsampat.
See #62112.

#5 @SergeyBiryukov
22 months ago

Twenty Nineteen: Remove trailing spaces in DocBlocks.

Follow-up to [59102].

Props mukesh27.
See #62112.

@viralsampat
22 months ago

Attachment 62112.2.patch added

I have checked above mentioned issue and founds few files. Here, I have added its patch.

#6 @sabernhardt
22 months ago

62112.2.patch proposes editing documentation in other themes, but those were already fixed last year (please update your files).

[56045] edited documentation for Twenty Twenty's filters.
[56118] documented the $current_screen and $is_IE variables in Twenty Twenty-One.

Note: See TracTickets for help on using tickets.

Download in other formats: