Make WordPress Core

Opened 7 weeks ago

Last modified 6 weeks ago

#62119 new feature request

Notice in Site Health in case revisions are disabled

Reported by: cewebdesignmunchen's profile cewebdesignmunchen Owned by:
Milestone: Awaiting Review Priority: normal
Severity: normal Version:
Component: Site Health Keywords: has-patch
Focuses: administration Cc:

Description

Feature request/idea: Give out a notice in Site Health in case revisions are disabled.
Feature request/idea: New setting in Settings>Writing: Limit revisions (maybe 3-300)

Change History (6)

#1 @sabernhardt
7 weeks ago

  • Component changed from General to Site Health

This ticket was mentioned in PR #7472 on WordPress/wordpress-develop by @tirth03.


6 weeks ago
#2

  • Keywords has-patch added

I've added a "Default Revision Limit" field in the Settings -> Writing page. Right now it is just HTML only which helps to store the value for revision limit. Other functionality in progress.

https://github.com/user-attachments/assets/68d59e52-267f-434b-ae63-6b78107aa3ea

#3 @tirth03
6 weeks ago

The initial Revision limit field is added.

Now, Where should I put the function to filter for the revision limit?

I'm also working on 'class-wp-site-health.php' for test. Let me know in which priority I should add it to. I think medium suits best, yet let me know.

#4 in reply to: ↑ description ; follow-up: @SergeyBiryukov
6 weeks ago

Hi there, thanks for the ticket!

Replying to cewebdesignmunchen:

Feature request/idea: Give out a notice in Site Health in case revisions are disabled.
Feature request/idea: New setting in Settings>Writing: Limit revisions (maybe 3-300)

I think these two ideas should be evaluated separately. A notice in Site Health would be helpful, but a new setting would go against the Decisions, not Options philosophy of WordPress.

For this ticket, I would suggest implementing the first idea, and then maybe creating another ticket for the second one.

#5 in reply to: ↑ 4 @cewebdesignmunchen
6 weeks ago

Replying to SergeyBiryukov:

Hi there, thanks for the ticket!

Replying to cewebdesignmunchen:

Feature request/idea: Give out a notice in Site Health in case revisions are disabled.
Feature request/idea: New setting in Settings>Writing: Limit revisions (maybe 3-300)

I think these two ideas should be evaluated separately. A notice in Site Health would be helpful, but a new setting would go against the Decisions, not Options philosophy of WordPress.

For this ticket, I would suggest implementing the first idea, and then maybe creating another ticket for the second one.

Thank you for the reply. Implementing the first idea would be great.

The second one can be ignored due to "Decisions, not Options". Thanks for the hint. That idea is not for the core then and might be (or already is?) for a plugin for users who want to control the number of revisions. Maybe an absolute limit (~10000?) in core to avoid problems? But if no one ever ran into problems, there is no need for this either?

Last edited 6 weeks ago by cewebdesignmunchen (previous) (diff)

This ticket was mentioned in PR #7481 on WordPress/wordpress-develop by @tirth03.


6 weeks ago
#6

I've added a notice in Site Health if the revision is disabled.

### If the revision is disabled

https://github.com/user-attachments/assets/ddf6fac6-d058-4003-b037-a2ba2a4a5a71

### If the revision is enabled

https://github.com/user-attachments/assets/9c4d00b6-2066-4d7c-aa2d-9834f09dc506

Trac ticket: (https://core.trac.wordpress.org/ticket/62119)

Note: See TracTickets for help on using tickets.