WordPress.org

Make WordPress Core

Opened 7 years ago

Closed 7 years ago

Last modified 7 years ago

#6212 closed defect (bug) (fixed)

Links inserted by media_buttons() contain unescaped ampersands

Reported by: Quandary Owned by:
Milestone: 2.6 Priority: normal
Severity: normal Version: 2.5
Component: TinyMCE Keywords:
Focuses: Cc:

Description

Title says it all; this prevents the post-new.php page from validating.

I've attached a trivial patch that fixes this problem (although post-new.php still doesn't validate due to dup IDs).

Attachments (1)

FixMediaUploadLinks.diff (1.8 KB) - added by Quandary 7 years ago.
Escape the ampersands found in the links

Download all attachments as: .zip

Change History (6)

@Quandary7 years ago

Escape the ampersands found in the links

comment:1 @ryan7 years ago

  • Resolution set to fixed
  • Status changed from new to closed

comment:2 @bradkovach7 years ago

  • Component changed from General to TinyMCE
  • Keywords has-patch removed
  • Milestone changed from 2.5 to 2.5.1
  • Resolution fixed deleted
  • Status changed from closed to reopened

Links that are inserted are now TOO escaped. When creating generic tutorial pages for a client, I tried inserting a video called "Learn Michael Jackson's Thriller" when I inserted the link, the editor showed "Learn Michael Jackson\'s Thriller"

I am running 2.5 fin

comment:3 @ryan7 years ago

  • Resolution set to fixed
  • Status changed from reopened to closed

That's a different issue. Closing since original issue is fixed.

comment:4 @ryan7 years ago

  • Milestone changed from 2.5.2 to 2.9

Milestone 2.5.2 deleted

comment:5 @westi7 years ago

  • Milestone changed from 2.9 to 2.6
Note: See TracTickets for help on using tickets.