Make WordPress Core

Opened 23 months ago

Closed 23 months ago

Last modified 23 months ago

#62144 closed defect (bug) (duplicate)

WordPress6.7.0 beta1 is generating a lot of Notices

Reported by: nendeb55 Owned by:
Priority: normal Milestone:
Component: I18N Version: 6.7
Severity: normal Keywords:
Cc: Focuses:

Description

WordPress6.7.0 beta1 is showing a lot of notices by plugins.

'Notice: Function load_plugin_textdomain was incorrectly called'

These are all the same Notice.

Here are some of the plugins that have been notified.
Firelight Lightbox
Show Current Template
Yoast Duplicate Post
User Role Editor
Widget Importer & Exporter
SiteGuard WP Plugin

Is this something that should be handled by the plugin?
Wouldn't it be better to get the word out first?

Change History (7)

#1 @tobifjellner
23 months ago

  • Resolutionworksforme
  • Status newclosed

Some plugins call load_plugin_textdomain() a bit too early, which may cause unexpected behavior.
This notice was added specifically to raise the awareness of these plugins' authors to this problem.

See https://core.trac.wordpress.org/changeset/59127

I'll close this ticket. If you want to discuss this further, then https://core.trac.wordpress.org/ticket/44937 is a better place.

Version 0, edited 23 months ago by tobifjellner (next)

#2 @swissspidy
23 months ago

  • Component GeneralI18N
  • Milestone Awaiting Review

Is this something that should be handled by the plugin?

Yes.

Wouldn't it be better to get the word out first?

A dev-note (blog post) will be published in time so that plugin developers can take appropriate action.

#3 @nendeb55
23 months ago

@tobifjellner @swissspidy

Thank you for your detailed explanation.

#4 @mukesh27
23 months ago

#62154 was marked as a duplicate.

#5 @neo2k23
23 months ago

It seems that every plugin is affected by this. They can not all be calling Function load_plugin_textdomain incorrectly. This change has a major impact on all plugin developers. So much for testing a beta release. The server logs get flooded by this change.

May i ask what after_setup_theme has todo with this? I get these notifications even in a clean install with a default wp theme (20-24)

Last edited 23 months ago by neo2k23 (previous) (diff)

#6 @swissspidy
23 months ago

@neo2k23 We're observing the impact of this and will make any necessary adjustments. Please follow #44937 and the make/core blog for any updates.

They can not all be calling Function load_plugin_textdomain incorrectly.

Yes they can :-)

May i ask what after_setup_theme has todo with this?

It is the earliest time where plugins are loaded, the theme is setup, and any classes relevant for translations are 100% available.

Again, please follow the original ticket and the make/core blog for any updates.

#7 @swissspidy
23 months ago

  • Resolution worksformeduplicate

Duplicate of #44937.

Note: See TracTickets for help on using tickets.