WordPress.org
Get WordPress

Make WordPress Core

Opened 6 months ago

Closed 6 months ago

Last modified 6 months ago

#62149 closed defect (bug) (fixed)

Interactivity API: Fix code formatting and add better types in docstrings

Reported by: czapla's profile czapla Owned by: czapla's profile czapla
Milestone: 6.7 Priority: normal
Severity: normal Version: 6.7
Component: Interactivity API Keywords: has-patch
Focuses: coding-standards Cc:

Description

Follow-up to #62136

Addresses minor formatting issues and adds better types in docstrings.

Change History (7)

This ticket was mentioned in ​PR #7474 on ​WordPress/wordpress-develop by ​@czapla.
6 months ago #1

  • Keywords has-patch added

Addresses minor formatting issues and adds better types in docstrings.

Following up on ​https://github.com/WordPress/wordpress-develop/pull/7460

#2 @czapla
6 months ago

  • Owner set to czapla
  • Resolution set to fixed
  • Status changed from new to closed

In 59153:

Interactivity API: Fix code formatting and add better types in docstrings.

Follow-up to [62136].

Props swissspidy.
Fixes #62149.

​@westonruter commented on ​PR #7474:
6 months ago #4

Props me too 😄

​@czapla commented on ​PR #7474:
6 months ago #5

Oh, my apologies, Weston! 🙏 I've just read ​https://make.wordpress.org/core/handbook/best-practices/contributor-attribution-props/ and realized that Props should be given much more liberally than I had thought.

Is there a way to add them post hoc?

​@westonruter commented on ​PR #7474:
6 months ago #6

No big deal! Just that since most of the PR consisted of my suggestions from the previous PR review, it seemed like I should have been on the props list.

You can fix up props in the Core Props screen on Make/Core: ​https://make.wordpress.org/core/wp-admin/admin.php?page=props-edit-core

​@czapla commented on ​PR #7474:
6 months ago #7

Done 👍

It doesn't appear in the changeset but it seems to have updated in the UI.

Note: See TracTickets for help on using tickets.