Make WordPress Core

Opened 5 months ago

Closed 3 months ago

Last modified 3 months ago

#62150 closed task (blessed) (fixed)

Update `$old_files` for 6.7 ensuring that deleted dirs from the SimplePie library are included.

Reported by: pbiron's profile pbiron Owned by: davidbaumwald's profile davidbaumwald
Milestone: 6.7 Priority: normal
Severity: normal Version: 6.7
Component: Upgrade/Install Keywords: has-patch dev-reviewed
Focuses: Cc:

Description (last modified by peterwilsoncc)

Update $_old_files for WordPress 6.7 -- @peterwilsoncc

-- Original ticket was for Simple Pie directories to action too, see below --

r59141 updated the SimplePie external library to 1.8.0. Part of that update is wholesale changes to the directory structure of the library.

In the past, there have been cases where moved files have been added to $_old_files but that old directories that end up empty have not been added to $_old_files.

This ticket is just to rise awareness of this SimplePie change to make sure that the old directories get added to $_old_files prior to the release of 6.7.

@davidbaumwald

Change History (23)

#1 @peterwilsoncc
4 months ago

Thanks for opening this, Paul.

Typically the old files array is updated late in the RC phase of the release cycle. Do you mind if I repurpose this ticket to be a generic ticket for updating the array?

#2 follow-up: @pbiron
4 months ago

Yes, I'm aware of when the changes to $_old_files happens...and the fact that the process is well documented in the handbook.

The specific purpose of this ticket is that there have been problems in the past with the tooling used to generate the changes for $_old_files where directories that used to exist but no longer do in the release being build don't get added to the array...and since it's known that 6.7 will have such directories that need to be deleted, I just wanted to make sure that they are included. That is, the list of files that no longer exist get added to the array but empty directories are aren't. This has resulted in the directories not being deleted when an update occurs.

So, if you want to repurpose the ticket to something like "make sure that the tooling correctly adds empty directories to the array" I'm fine with that...but repurposing it as "follow the handbook about updating $_old_files isn't really appropriate, IMHO.

#3 in reply to: ↑ 2 @peterwilsoncc
4 months ago

Replying to pbiron:

The specific purpose of this ticket is that there have been problems in the past with the tooling used to generate the changes for $_old_files where directories that used to exist but no longer do in the release being build don't get added to the array...and since it's known that 6.7 will have such directories that need to be deleted, I just wanted to make sure that they are included.

Got it, thanks Paul.

I wasn't aware of the problem and would have totally missed that.

Reviewing the WP-CLI upgrade output, the SimplePie portion of the old files will need to be:

// Files
wp-includes/SimplePie/Author.php
wp-includes/SimplePie/Cache.php
wp-includes/SimplePie/Caption.php
wp-includes/SimplePie/Category.php
wp-includes/SimplePie/Copyright.php
wp-includes/SimplePie/Core.php
wp-includes/SimplePie/Credit.php
wp-includes/SimplePie/Enclosure.php
wp-includes/SimplePie/Exception.php
wp-includes/SimplePie/File.php
wp-includes/SimplePie/gzdecode.php
wp-includes/SimplePie/IRI.php
wp-includes/SimplePie/Item.php
wp-includes/SimplePie/Locator.php
wp-includes/SimplePie/Misc.php
wp-includes/SimplePie/Parser.php
wp-includes/SimplePie/Rating.php
wp-includes/SimplePie/Registry.php
wp-includes/SimplePie/Restriction.php
wp-includes/SimplePie/Sanitize.php
wp-includes/SimplePie/Source.php

// Directories
wp-includes/SimplePie/Cache/
wp-includes/SimplePie/Content/
wp-includes/SimplePie/Decode/
wp-includes/SimplePie/HTTP/
wp-includes/SimplePie/Net/
wp-includes/SimplePie/Parse/
wp-includes/SimplePie/XML/

#4 @peterwilsoncc
4 months ago

  • Description modified (diff)
  • Summary changed from ensure that deleted dirs from the SimplePie library are included in `$_old_files` prior to release of 6.7 to Update `$old_files` for 6.7 ensuring that deleted dirs from the SimplePie library are included.

This ticket was mentioned in PR #7594 on WordPress/wordpress-develop by @peterwilsoncc.


4 months ago
#5

  • Keywords has-patch added

#6 @peterwilsoncc
4 months ago

I ended up updating the ticket to cover both the general update with the specific focus on the SimplePie directories included.

Please see the linked pull request.

@peterwilsoncc commented on PR #7594:


4 months ago
#7

Proposed commit message:

Upgrade/Install: Update the $_old_files array for 6.7.

Update the array of files to be removed during the upgrade routine for WordPress 6.7. The upgrade of the SimplePie library in [59141] included a significant refactor requiring a number directories be removed.

Props, fixes, etc

@pbiron commented on PR #7594:


4 months ago
#8

Not necessary, but wouldn't hurt to add a reference to https://core.trac.wordpress.org/changeset/59141 in this comment.

I now realize I did something wrong. I meant the above to be "add that reference to comment at the being of the PR that explains about the SimplePie update" ;-)

@peterwilsoncc commented on PR #7594:


4 months ago
#9

I now realize I did something wrong. I meant the above to be "add that reference to comment at the being of the PR that explains about the SimplePie update" ;-)

Yes, that makes way more sense. Pushed. It's early, that's my excuse for misunderstanding ;)

This ticket was mentioned in Slack in #core by chaion07. View the logs.


4 months ago

This ticket was mentioned in Slack in #core by chaion07. View the logs.


4 months ago

This ticket was mentioned in Slack in #core by stoyangeorgiev. View the logs.


3 months ago

This ticket was mentioned in Slack in #core by stoyangeorgiev. View the logs.


3 months ago

This ticket was mentioned in Slack in #core by chaion07. View the logs.


3 months ago

#15 @peterwilsoncc
3 months ago

I've rechecked the list with an upgrade from 6.6.2 to 6.7-RC4 to ensure nothing has changed since I first created the PR. I think it still looks good but would appreciate if someone else could re-validate it too.

I've just pushed a minor update to the PR to sort the file names alphabetically-ish.

#16 @fazyshah
3 months ago

  • Resolution set to invalid
  • Status changed from new to closed

I just created a new install WP Core 6.6.2 and checked wp-includes/SimplePie

// Files
Parser.php
Sanitize.php
Core.php
Category.php
gzdecode.php
Locator.php
Author.php
Cache.php
IRI.php
Credit.php
Restriction.php
Item.php
Source.php
Registry.php
Rating.php
Copyright.php
Exception.php
Misc.php
Caption.php
File.php
Enclosure.php

// Directories
Cache
Content
Decode
HTTP
Net
Parse
XML
library
src

Then I upgraded via WP CLI to WP Core 6.7-RC4 and checked again.

// Files
autoloader.php

// Directories
Cache
Content
Decode
HTTP
Net
Parse
XML
library
src

#17 @fazyshah
3 months ago

  • Resolution invalid deleted
  • Status changed from closed to reopened

This ticket was mentioned in Slack in #core by stoyangeorgiev. View the logs.


3 months ago

#19 @davidbaumwald
3 months ago

  • Owner set to davidbaumwald
  • Resolution set to fixed
  • Status changed from reopened to closed

In 59386:

Upgrade/Install: Update the $_old_files array for 6.7.

Props pbiron, peterwilsoncc, fazyshah.
Fixes #62150.

#20 @davidbaumwald
3 months ago

  • Keywords dev-feedback added
  • Resolution fixed deleted
  • Status changed from closed to reopened

Reopening for dev-feedback to merge to the 6.7 branch.

#21 @jorbin
3 months ago

  • Keywords dev-reviewed added; dev-feedback removed

[59386] looks good for backport to the 6.7 branch

Reviewed by comparing the commit to svn diff --summarize https://core.svn.wordpress.org/tags/6.6.2 https://core.svn.wordpress.org/branches/6.7 | grep '^D' | sort

#22 @davidbaumwald
3 months ago

  • Resolution set to fixed
  • Status changed from reopened to closed

In 59387:

Upgrade/Install: Update the $_old_files array for 6.7.

Reviewed by jorbin.
Merges [59386] to the 6.7 branch.

Props pbiron, peterwilsoncc, fazyshah.
Fixes #62150.

Note: See TracTickets for help on using tickets.