WordPress.org
Get WordPress

Make WordPress Core

Opened 2 years ago

Closed 2 years ago

Last modified 2 years ago

#62160 closed defect (bug) (fixed)

Twenty Sixteen : PHPCS Fixes

Reported by: pitamdey Owned by: SergeyBiryukov
Priority: normal Milestone: 6.7
Component: Bundled Theme Version:
Severity: normal Keywords: has-patch commit
Cc: Focuses: coding-standards

Description

In theme Twenty Sixteen,
I have found a few PHPCS errors like

  • There must be exactly one blank line after the file comment

I have applied a patch which will fix this issue.

Attachments (2)

phpcs-fixes.patch​ (3.8 KB ) - added by pitamdey 2 years ago.
62160.patch​ (15.0 KB ) - added by viralsampat 2 years ago.
I have checked above mentioned issue into the other themes and I found few files where we need to make this change. I have updated those files and added my patch for the same.

Download all attachments as: .zip

Change History (11)

@pitamdey
2 years ago

#1 @mukesh27
2 years ago

  • Milestone Awaiting Review → 6.7

Thanks for the ticket and patch!

Could you share the command so we can solve the issue for whole codebase?

Similar ticket #62098

This ticket was mentioned in ​PR #7487 on ​WordPress/wordpress-develop by ​@umeshsinghin.
2 years ago #2

<!--
Trac 62160

#3 @umeshsinghin
2 years ago

We have fixed PHPCS #7487

#5 @deepakrohilla
2 years ago

@nithins53: Yes he is referring ​https://github.com/WordPress/wordpress-develop/pull/7487 this PR , i think he accidentally added "We have fixed PHPCS #7487" this.

@viralsampat
2 years ago

I have checked above mentioned issue into the other themes and I found few files where we need to make this change. I have updated those files and added my patch for the same.

#6 @nithins53
2 years ago

Thank you for the patch @viralsampat. Guess we can solve the issues for the rest of the codebase @mukesh27

#7 @sabernhardt
2 years ago

  • Keywords commit added

​PR 7487 just adds a line after the file header for nine files in Twenty Sixteen, which is consistent with the recent changes in [59158].

#62166 could address the rest of the themes. PR 7500 already includes the valid parts of 62160.patch.

#8 @SergeyBiryukov
2 years ago

  • Owner set to SergeyBiryukov
  • Resolution → fixed
  • Status new → closed

In 59173:

Twenty Sixteen: Fix PHPCS issues.

There must be exactly one blank line after the file comment.

Follow-up to [40851].

Props pitamdey, umeshsinghin, sabernhardt, mukesh27, nithins53, deepakrohilla, viralsampat.
Fixes #62160.

​@SergeyBiryukov commented on ​PR #7487:
2 years ago #9

Thanks for the PR! Merged in r59173.

Note: See TracTickets for help on using tickets.