Opened 14 months ago
Closed 14 months ago
#62162 closed defect (bug) (invalid)
Check PHPcs Coding standard into the wp-admin folder
| Reported by: |
|
Owned by: | |
|---|---|---|---|
| Milestone: | Priority: | normal | |
| Severity: | normal | Version: | |
| Component: | General | Keywords: | |
| Focuses: | Cc: |
Description
Hello Team,
I have reviewed the code and found a few errors in some of the below files. Please below files:
Files:
wp-admin/includes/class-theme-upgrader.php
wp-admin/includes/class-wp-debug-data.php
wp-admin/includes/class-wp-ms-sites-list-table.php
Thanks,
Attachments (1)
Change History (3)
#2
@
14 months ago
- Keywords dev-feedback removed
- Milestone Awaiting Review deleted
- Resolution set to invalid
- Status changed from new to closed
These proposed changes are not appropriate.
- Even if
Theme_Upgrader::delete_old_theme()does not use the$local_destinationand$remote_destinationparameters, it uses the$themeparameter (at the end of the list) and theupgrader_clear_destinationhook expects 4 arguments. All parameters need to stay in the method and its documentation. - [54953] and [54954] already documented
$_wp_theme_featuresinWP_Debug_Data::debug_data()and$wpdbinWP_Debug_Data::get_database_size(). - [58745] already removed the
$modedocumentation inWP_MS_Sites_List_Table::display_rows().
Note: See
TracTickets for help on using
tickets.
#62161 was marked as a duplicate.