Make WordPress Core

Opened 2 months ago

Closed 2 months ago

#62162 closed defect (bug) (invalid)

Check PHPcs Coding standard into the wp-admin folder

Reported by: viralsampat's profile viralsampat Owned by:
Milestone: Priority: normal
Severity: normal Version:
Component: General Keywords:
Focuses: Cc:

Description

Hello Team,

I have reviewed the code and found a few errors in some of the below files. Please below files:

Files:

wp-admin/includes/class-theme-upgrader.php
wp-admin/includes/class-wp-debug-data.php
wp-admin/includes/class-wp-ms-sites-list-table.php

Thanks,

Attachments (1)

62162.patch (1.8 KB) - added by viralsampat 2 months ago.

Download all attachments as: .zip

Change History (3)

@viralsampat
2 months ago

#1 @SergeyBiryukov
2 months ago

#62161 was marked as a duplicate.

#2 @sabernhardt
2 months ago

  • Keywords dev-feedback removed
  • Milestone Awaiting Review deleted
  • Resolution set to invalid
  • Status changed from new to closed

These proposed changes are not appropriate.

  1. Even if Theme_Upgrader::delete_old_theme() does not use the $local_destination and $remote_destination parameters, it uses the $theme parameter (at the end of the list) and the upgrader_clear_destination hook expects 4 arguments. All parameters need to stay in the method and its documentation.
  2. [54953] and [54954] already documented $_wp_theme_features in WP_Debug_Data::debug_data() and $wpdb in WP_Debug_Data::get_database_size().
  3. [58745] already removed the $mode documentation in WP_MS_Sites_List_Table::display_rows().
Note: See TracTickets for help on using tickets.