Fix PHPCS "Yoda Condition checks" of WordPress Core file media.php.

[deepakrohilla]

in wp-includes/media.php file Fix PHPCS "Yoda Condition checks" needs to be fixed

In this ticket I am adding patch to fix PHPCS "Yoda Condition checks" errors in media.php.

https://core.trac.wordpress.org/ticket/62164

[debarghyabanerjee]

Hi @deepakrohilla, Thanks for reporting this, but I don't think this is needed/required as it doesn't involve a comparison with a variable, rather with the count.

Please also check: ​https://developer.wordpress.org/coding-standards/wordpress-coding-standards/php/#yoda-conditions

This patch should not be applied, as it doesn't involve comparison with a variable.

Yes, makes sense to not merge this, as purpose of using YODA condition is to throw error if we accidentally use = (assignment) instead of == (comparison ),

• here the order doesn't matter as we can not assign any value to a function's return value anyways ( it will throw error )

The ticket was closed. Feel free to reopen.