Bundled themes: PHPCS "exactly one blank line after the file comment"

[dhruvang21]

This ticket is created to serve as the base for resolving the phpcs error such as
"There must be exactly one blank line after the file comment" for the whole codebase

Command to check for this Error :-
phpcs --standard=WordPress --extensions=php file_path

Currently the error has been resolved in the following themes:-

Twenty Thirteen, Twenty Fifteen :- By this patch 62160.patch

Twenty Fourteen: #62098 / [59158]

Twenty Sixteen: #62160

[dhruvang21]

hello @mukesh27,

Command you asked for checking the error is mentioned in the ticket description and working on resolving the error by creating Patch for the other theme as well.

[parthvataliya]

Fix phpcs error for following themes:

[parthvataliya]

Fix phpcs error for following themes:

[parthvataliya]

Fix phpcs error for following themes: seventeen, nineteen, twenty, twenty-one, twenty-two, twenty-three,

[dhruvang21]

Fixes phpcs error for theme twentyeleven and twentytwelve

[nithins53]

Guess this covers all the themes now.

Trac ticket: https://core.trac.wordpress.org/ticket/62166

Fixes PHPCS Error :- "There must be exactly one blank line after the file comment"

[sabernhardt]

In PR 7500, I marked one line that should not be added in Twenty Twenty-Two's ​block-patterns file (out of 187 files).

Additional notes:

• The error is ​'SpacingAfterComment' from PHPCS.
• Core-40039 only updated Twenty Seventeen and newer themes for different coding standards two years ago. However, [59158] already made 'SpacingAfterComment' changes for Twenty Fourteen, and consistency is good.

[sabernhardt]

I did not add the 'changes-requested' keyword, but what I requested is done now :)

[mdviralsampat]

I have checked another theme and core files and found above mentioned change. I have resolved it and added its patch for the same.

[poena]

Hi @dhruvang21 @mdviralsampat
When I compare the patches and the pull request, I do not see any theme related changes in the patches that are not already part of the pull request, can you please confirm this?
It is not clear to me why multiple patches were submitted.

The patches contain changes that are unrelated to the themes, and those changes must not be committed as part of this ticket.

[dhruvang21]

Hi @poena,

I have made changes only in the theme files since this ticket specifically addresses resolving the PHPCS issues within themes. I believe @mdviralsampat submitted a patch for the core file as well, but I have not included those changes in my PR.

[viralsampat]

I have checked twenty twenty four theme and found few files where we need to resolve phpcs errors/warnings. I have resolved it and added its patch for the same.

I checked each of the PHP files and found one more with an extra line (to remove): twentytwentythree\functions.php.

[sabernhardt]

PR 7500 does not edit the following class files, and I am not sure whether this ticket should change them.

• twentyeleven\inc\widgets.php
• twentyfourteen\inc\featured-content.php
• twentyfourteen\inc\widgets.php

I do not think that they should simply add an empty line between the comment and the class Featured_Content { line. However, the two widget class files seem to combine the file header and the class docblock (compared to how ​Twenty Nineteen separates them).

#62437 can address any edits to package/subpackage/since details in block themes such as Twenty Twenty-Four (62166.5.patch).

Co-authored by dhruvang21

Adds empty line below file header comment to meet PHPCS 'SpacingAfterComment' rule in classic theme PHP files if it was not already there.

• T10 (8 of 22)
• T11 (15 of 33, including inc/widgets.php)
• T12 (7 of 28)
• T13 (14 of 32)
• T14 (3 of 39, including inc/featured-content.php and inc/widgets.php)
• T15 (8 of 23)
• T19 (1 of 31)

Additional changes:

• Splitting the file header comment from the class docblock for the Twenty_Eleven_Ephemera_Widget, Twenty_Fourteen_Ephemera_Widget, and Featured_Content classes.
• Adding the since note in twentyeleven/index.php.
• Correcting the version number format in twentynineteen/inc/back-compat.php.

Trac 62166

Use of AI Tools: none by me

I built off of this to make #12386, focusing on the classic themes because #8379 can add the empty lines for the block themes.

The issue with block themes was fixed in r62867. By merging the trunk branch into this PR, this PR ultimately only contains changes to classic themes.