Make WordPress Core

Opened 4 months ago

Last modified 19 hours ago

#62220 new task (blessed)

Update/Audit NPM Dependencies for 6.8

Reported by: desrosj's profile desrosj Owned by:
Milestone: 6.8 Priority: normal
Severity: normal Version:
Component: Build/Test Tools Keywords: has-patch
Focuses: Cc:

Description

Previously:

Change History (12)

This ticket was mentioned in PR #7996 on WordPress/wordpress-develop by @desrosj.


2 months ago
#1

  • Keywords has-patch added

@Bernhard Reiter commented on PR #7996:


8 weeks ago
#2

👋 @desrosj Are you planning to land this in the near future (i.e. well before WP 6.8 Beta 1)?

(FWIW, I'd love that, as I have a janitorial PR that requires a package update 😊)

@desrosj commented on PR #7996:


8 weeks ago
#3

@ockham I plan to merge this sometime next week! But it's not a high priority.

Is the concern a merge conflict? Or something else? Don't feel blocked to commit your PR if it's ready and I'll adjust. 😄

@Bernhard Reiter commented on PR #7996:


8 weeks ago
#4

@ockham I plan to merge this sometime next week! But it's not a high priority.

Is the concern a merge conflict? Or something else? Don't feel blocked to commit your PR if it's ready and I'll adjust. 😄

Thank you, but I really can't land mine before a package update 😅 A while ago, I removed some now-obsolete functions from the Navigation block's PHP in Gutenberg. My PR moves -- or rather copies -- them to deprecated.php. But that means that they're colliding with the function declarations that still exist in Core's navigation.php -- until that file is updated by a package sync.

I hope that made sense. But again, not urgent at all -- any time before Beta 1 is fine 😄

#5 @desrosj
8 weeks ago

In 59509:

Build/Test Tools: Update devDependencies.

This updates the following devDependencies:

  • dotenv from 16.4.5 to 16.4.7
  • dotenv-expand from 11.0.6 to 12.0.1
  • postcss from 8.4.47 to 8.4.49
  • qunit from 2.22.0 to 2.23.1
  • sass from 1.79.4 to 1.79.6
  • terser-webpack-plugin from 5.3.10 to 5.3.11
  • uglify-js from 3.17.4 to 3.19.3
  • uuid from 9.0.1 to 11.0.3
  • webpack from 5.90.2 to 5.97.1

Additionally, npm audit fix has been run.

Follow up to [58585].

See #62220.

@desrosj commented on PR #7996:


8 weeks ago
#6

@ockham Merged in https://core.trac.wordpress.org/changeset/59509!

There are a few other dependencies with updates that need more work in order to be usable (sinon's update causes test failures, for example). But won't get to those for a bit.

@Bernhard Reiter commented on PR #7996:


8 weeks ago
#7

Aaand this is where I realize that this PR was about updating 3rd party dependencies, rather than @wordpress/ packages. In my head, I totally equated "Update NPM packages" with "Sync @wordpress/ NPM packages".
Bonus points for me for never actually checking the diff 🤦‍♂️

Anyway. Sorry for the noise. Nothing to see here. Carry on.

Unprops @ockham.

@desrosj commented on PR #7996:


8 weeks ago
#8

Sorry! I should have been more specific that it was only devDependencies! No worries!

#10 @desrosj
7 weeks ago

In 59530:

Build/Test Tools: Update Default Theme devDependencies.

The devDependencies for all default themes with package.json files (Twenty Nineteen, Twenty Twenty, and Twenty Twenty-One) are now updated to their latest versions with a few exceptions in Twenty Twenty-One:

  • Upgrading stylelint/@wordpress/stylelint-config requires some work to address rule deprecations.
  • @wordpress/eslint-plugin does not yet support eslint 9.x.

Additionally, npm audit fix has been run for each theme.
See #62220.

#12 @desrosj
19 hours ago

In 59768:

Build/Test Tools: Configure UglifyJS to preserve previous behavior.

As of UglifyJS >= 3.18.0, the default behavior is to process input as an ES module. This updates the relevant configurations to ensure the build process continues to use the previous behavior to avoid JavaScript errors in the minified versions of files.

Follow up to [58563], [58586], and [59509].

Props siliconforks, nataliat2004, poena, mai21, SergeyBiryukov.
Fixes #62767. See #61519, #62220.

Note: See TracTickets for help on using tickets.