Make WordPress Core

Opened 22 months ago

Closed 22 months ago

Last modified 15 months ago

#62231 closed defect (bug) (fixed)

Font faces defined in variations aren't loaded in the browser until the variation switch is saved and the page is refreshed

Reported by: mmaattiiaass Owned by: peterwilsoncc
Priority: normal Milestone: 6.7
Component: Editor Version: 6.7
Severity: normal Keywords: has-patch has-unit-tests needs-testing has-test-info
Cc: Focuses:

Description

Description
When switching style variations, the font faces defined in those variations are not loaded in the editor but after the page is reloaded.

Step-by-step reproduction instructions
Switch to a theme style variation with custom font faces defined.
Check that the fonts are not loaded in the editor until the page is refreshed (browser reload).

Originally reported in GitHub repo: https://github.com/WordPress/gutenberg/issues/59965

Change History (11)

This ticket was mentioned in PR #7570 on WordPress/wordpress-develop by @mmaattiiaass.


22 months ago
#1

  • Keywords has-patch has-unit-tests added

Resolve theme relative font faces URIs in theme.json and style variations.
Porting this change from Gutenberg repo: https://github.com/WordPress/gutenberg/pull/65019

Trac ticket: [](https://core.trac.wordpress.org/ticket/62231)

This ticket was mentioned in PR #7581 on WordPress/wordpress-develop by @mmaattiiaass.


22 months ago
#2

Load fonts from style variations only in the editor and admin, not in the public frontend.

This is an alternative and probably simpler alternative to the Gutenberg PR: https://github.com/WordPress/gutenberg/pull/65019 and it core port PR: https://github.com/WordPress/wordpress-develop/pull/7570

Trac ticket: https://core.trac.wordpress.org/ticket/62231

#3 @ironprogrammer
22 months ago

  • Keywords needs-testing has-testing-info added

This ticket was mentioned in Slack in #core-test by ironprogrammer. View the logs.


22 months ago

#5 @ironprogrammer
22 months ago

  • Component GeneralEditor
  • Milestone Awaiting Review6.7

Thanks for the patch and convenient test theme, @mmaattiiaass! This PR works as advertised in my testing, and I've moved this ticket to the 6.7 milestone for visibility (it's already on the 6.7 editor board). (Note that the first PR did not work for me.)

Test Report

Patch tested: https://github.com/WordPress/wordpress-develop/pull/7581 (second, "simpler alternative" PR)

Environment

  • Hardware: MacBook Pro Apple M1 Pro
  • OS: macOS 14.6.1
  • Browser: Safari 17.6
  • Server: nginx/1.27.1
  • PHP: 8.3.12
  • MySQL: 8.0.27
  • WordPress: 6.7-beta3-59237-src
  • Theme: font-variants (zip from PR description)

Actual Results

  • ✅ Custom fonts in style variations are immediately and accurately reflected in the style thumbnails and editor preview. No page refresh is needed to show the custom fonts.

Supplemental Artifacts

Click an image for a large version.

Left Styles browser Right Styles browser
https://cldup.com/N4WSNmDnaY-2000x2000.png https://cldup.com/ETmPwV9NnY-2000x2000.png

Prefer videos? See these before patch and after patch recordings.

#6 @peterwilsoncc
22 months ago

  • Owner set to peterwilsoncc
  • Resolutionfixed
  • Status newclosed

In 59260:

Editor: Load all style variation fonts within the editors.

Loads the font family files from style variations defined within a theme for user in the site and post editors. This is to ensure the fonts are shown while editing without the need for a reload after switching styles.

Props ironprogrammer, mmaattiiaass.
Fixes #62231.

#8 @ugyensupport
22 months ago

Font faces defined in variations aren't loaded in the browser until the variation switch is saved and the page is refreshed

Description

When switching style variations, the font faces defined in those variations are not loaded in the editor but after the page is reloaded.

Steps

Switch to a theme style variation with custom font faces defined.
Check that the fonts are not loaded in the editor until the page is refreshed (browser reload).

Patch tested:
https://github.com/WordPress/wordpress-develop/pull/7581/files
https://github.com/WordPress/wordpress-develop/pull/7570/files

Environment

  • WordPress: 6.7-beta3
  • PHP: 8.3.10
  • Server: nginx/1.21.4
  • Database: mysqli (Server: 5.7.44-log / Client: mysqlnd 8.3.10)
  • Browser: Chrome 129.0.0.0
  • OS: macOS
  • Theme: Twenty Twenty-Five 1.0
  • MU Plugins: None activated
  • Plugins:
    • Akismet Anti-spam: Spam Protection 5.3.3
    • Gutenberg 19.4.0
    • Test Reports 1.1.0
    • WordPress Beta Tester 3.6.0

Actual Results

  1. ✅ Issue resolved with patch.

As mentioned by @ironprogrammer
Custom fonts in style variations are immediately and accurately reflected in the style
thumbnails and editor preview. No page refresh is needed to show the custom fonts.

Supplemental Artifacts

Before: https://vioo.cc/v/1x0

After : https://vioo.cc/v/Yh7

Version 0, edited 22 months ago by ugyensupport (next)

@ramonopoly commented on PR #7570:


22 months ago
#9

Should we close this since https://github.com/WordPress/gutenberg/pull/65019 was closed?

@mmaattiiaass commented on PR #7570:


22 months ago
#10

Should we close this since https://github.com/WordPress/gutenberg/pull/65019 was closed?

Yes, let's close this. An alternative approach has been already merged.

#11 @wordpressdotorg
15 months ago

  • Keywords has-test-info added; has-testing-info removed
Note: See TracTickets for help on using tickets.