Bundled Themes: avoid triggering translation loading too early

[domainsupport]

As per #44937 we are seeing this error notice with Twenty Twenty bundled theme when testing with WordPress v6.7-beta3 ...

[16-Oct-2024 11:08:39 UTC] E_USER_NOTICE: Function _load_textdomain_just_in_time was called incorrectly. Translation loading for the twentytwenty domain was triggered too early. This is usually an indicator for some code in the plugin or theme running too early. Translations should be loaded at the init action or later. Please see Debugging in WordPress for more information. (This message was added in version 6.7.0.) in /wp-includes/functions.php on line 6099

We are also seeing similar notices with Twenty Seventeen and Twenty Nineteen. Do they require additional tickets or can all be dealt with in this ticket?

Oliver

[swissspidy]

Good catch! We can fix this all in the same ticket.

Trac ticket: https://core.trac.wordpress.org/ticket/62237

[domainsupport]

Ah, sorry, just spotted the same in Twenty Fifteen, Twenty Sixteen, Twenty Ten, Twenty Thirteen, Twenty Twelve and Twenty Fourteen!

[swissspidy]

No problem, I just updated the PR accordingly.

[peterwilsoncc]

In 59244:

Bundled Themes: Avoid loading translations too early.

Load block patterns for bundled themes on the init hook to avoid triggering notices caused by loading the translations too early.

The change is applied to Twenty Ten, Twenty Twelve, Twenty Thirteen, Twenty Fourteen, Twenty Fifteen, Twenty Sixteen and Twenty Twenty.

Props domainsupport, swissspidy.
Fixes #62237.
See #44937.

Merged r59244 / ​https://github.com/WordPress/wordpress-develop/commit/333272d62390799ba604655357d7984f143a3de9