wp_insert_post should check the return value of $wpdb->query or use $wpdb->escape

[BenDeRydt]

I'd tried using wp_insert_post as described in ​the function reference. This caused major problems with post_content like --it's a rainy day-- because:

1. wp_insert_post does not escape its query parameters

2. it does not check the return value of $wpdb->query

This meant that I got a perfectly innocent ID in return which I used in other tables but there never was a post with this ID in the actual wp_posts table. Worst of all, WordPress cached some info of this post in its postcache, meaning I got a half finished post on the frontpage of my blog but no way to link to it.

[BenDeRydt]

Sorry, wrong title. I meant $wpdb->escape.

[ryan]

(In [7900]) wp_insert_post() -- Validate page template, check return of insert and update queries, add option to return WP_Error. fixes #6227 see #6098

[ryan]

(In [7920]) wp_insert_post() -- Validate page template, check return of insert and update queries, add option to return WP_Error. fixes #6227 see #6098. for 2.5