WordPress.org

Make WordPress Core

Opened 6 years ago

Closed 6 years ago

#6228 closed defect (bug) (fixed)

Reduce dependency on inline style

Reported by: mdawaffe Owned by: mdawaffe
Milestone: 2.5 Priority: normal
Severity: normal Version: 2.5
Component: General Keywords: css rtl has-patch commit
Focuses: Cc:

Description

The new design implementation has a lot of inline style. WordPress has historically stayed away from inline styling to aid skinners and, more importantly, RTL users.

Attached:

  1. Uses alignleft and alignright classes instead of hardcoded floats.
  2. Uses new textleft and textright classes instead of hardcoded text-aligns.
  3. Uses check-column and new num class to center those table columns rather than hardcoded text-aligns. Also simplifies and standardizes check-column markup.
  4. Replaces <br style="clear: both;" /> with <br class="clear" />.
  5. Uses new button-highlighted class instead of hardcoded font-weights.
  6. Adds to css/theme-editor.css file to get rid of hardcoded styling in the theme and plugin editors.

Attachments (2)

6228.diff (28.4 KB) - added by mdawaffe 6 years ago.
6228.b.diff (6.5 KB) - added by mdawaffe 6 years ago.

Download all attachments as: .zip

Change History (6)

mdawaffe6 years ago

comment:1 ryan6 years ago

  • Resolution set to fixed
  • Status changed from new to closed

(In [7304]) Reduce dependency on inline style. Props mdawaffe. fixes #6228

comment:2 mdawaffe6 years ago

  • Resolution fixed deleted
  • Status changed from closed to reopened

Couple of minor bugs. I'll have a patch soon.

mdawaffe6 years ago

comment:3 mdawaffe6 years ago

  • Keywords has-patch commit added
  • Owner changed from anonymous to mdawaffe
  • Status changed from reopened to new

comment:4 ryan6 years ago

  • Resolution set to fixed
  • Status changed from new to closed

(In [7307]) Reduce dependency on inline style. Props mdawaffe. fixes #6228

Note: See TracTickets for help on using tickets.