Make WordPress Core

Opened 8 weeks ago

Closed 12 days ago

#62282 closed defect (bug) (fixed)

Twenty Thirteen & Twenty Sixteen: Latest Comments block has top border for first item in editor

Reported by: viralsampat's profile viralsampat Owned by: poena's profile poena
Milestone: 6.8 Priority: normal
Severity: normal Version: 5.8
Component: Bundled Theme Keywords: has-patch commit
Focuses: css Cc:

Description

Hello Team,

I have checked "Latest Comments" block into the twenty-thirteen/twenty-sixteen themes and found that the top border is not displaying into the front-end side for above mentioned both the themes.

I think that it should be same in both the sides(Back-end & Front-end ).

For, better understanding here, I have attached screenshots

Thanks,

Attachments (14)

twenty-thirteen-latest-comments-block-editor-side.png (226.0 KB) - added by viralsampat 8 weeks ago.
Twenty Thirteen Back-end
twenty-thirteen-latest-comments-block-front-end-side.png (275.0 KB) - added by viralsampat 8 weeks ago.
Twenty Thirteen Front-end
twenty-sixteen-latest-comments-block-editor-side.png (227.1 KB) - added by viralsampat 8 weeks ago.
Twenty Sixteen Front-end
twenty-sixteen-latest-comments-block-front-end-side.png (161.7 KB) - added by viralsampat 8 weeks ago.
Twenty Sixteen Front-end
62282.patch (1016 bytes) - added by viralsampat 7 weeks ago.
I have checked above mentioned issue and I have resolved it and added patch. Also, I have attached screenshot after resolved this issue.
after-resolved-twenty-thirteen-latest-comments-block-editor-side.png (229.3 KB) - added by viralsampat 7 weeks ago.
After resolved issue Back-end:
after-resolved-twenty-thirteen-latest-comments-block-front-end-side.png (279.7 KB) - added by viralsampat 7 weeks ago.
After resolved issue front-end:
after-resolved-twenty-sixteen-latest-comments-block-editor-side.png (223.7 KB) - added by viralsampat 7 weeks ago.
After resolved issue Back-end:
after-resolved-twenty-sixteen-latest-comments-block-front-end-side.png (163.9 KB) - added by viralsampat 7 weeks ago.
After resolved issue front-end:
62282.1.patch (1.4 KB) - added by sabernhardt 7 weeks ago.
adds :not(:first-child) to selectors in editor-blocks.css and updates meta link selector
t13-before-62282.1 .png (84.2 KB) - added by parthvataliya 3 weeks ago.
Twenty thirteen theme before patch
t13-after-62282.1 .png (84.9 KB) - added by parthvataliya 3 weeks ago.
Twenty thirteen theme after patch
t16-before-62282.1 .png (86.6 KB) - added by parthvataliya 3 weeks ago.
Twenty sixteen theme before patch
t16-after-62282.1 .png (87.0 KB) - added by parthvataliya 3 weeks ago.
Twenty sixteen theme after patch

Change History (20)

@viralsampat
7 weeks ago

I have checked above mentioned issue and I have resolved it and added patch. Also, I have attached screenshot after resolved this issue.

@sabernhardt
7 weeks ago

adds :not(:first-child) to selectors in editor-blocks.css and updates meta link selector

#1 @sabernhardt
7 weeks ago

  • Keywords dev-feedback removed
  • Milestone changed from Awaiting Review to 6.8
  • Summary changed from Twenty Thirteen/& Twenty Sixteen Themes: The Latest comments block top border is not appear into the front-end side. to Twenty Thirteen & Twenty Sixteen: Latest Comments block has top border for first item in editor
  • Version set to 5.8

[51205] purposely removed the top border from the first item on the front end, but it did not change the editor styles to match.

In addition to updating the comment selectors for both themes, 62282.1.patch replaces the outdated .editor-block-list__block class in Twenty Sixteen's meta link selector. Note that I did not change the class name in Twenty Thirteen's stylesheet because margin: 0 was intended for an earlier version of WordPress (and inappropriate with more recent versions).

Version 0, edited 7 weeks ago by sabernhardt (next)

#2 @aishwarryapande
4 weeks ago

Test Report

Patch tested: https://core.trac.wordpress.org/attachment/ticket/62282/62282.1.patch
Environment:
OS: Windows 11
Browser: Chrome
PHP: 8.3
Theme: Twenty Thirteen and Twenty Sixteen.

Result: The top border line in the Twenty thirteen and sixteen is not visible now on the editor screen.

Status : It is working fine after patch.

Screenshots :

Theme: twentythirteen
Before :
https://share.nmblc.cloud/c2011a44

After :
https://share.nmblc.cloud/c9e52c47

Theme : Twenty Sixteen
Before :
https://share.nmblc.cloud/af343540

After :
https://share.nmblc.cloud/776eb527

Last edited 3 weeks ago by aishwarryapande (previous) (diff)

#3 @parthvataliya
3 weeks ago

Test Report

Description

This report validates whether the indicated patch works as expected.

Patch tested: https://core.trac.wordpress.org/attachment/ticket/62282/62282.1.patch

Environment

  • WordPress: 6.8-alpha-59274-src
  • PHP: 8.2.22
  • Server: nginx/1.27.0
  • Database: mysqli (Server: 8.0.39 / Client: mysqlnd 8.2.22)
  • Browser: Chrome 129.0.0.0
  • OS: Linux
  • Theme: Twenty Thirteen 4.3 and Twenty Sixteen 3.4
  • MU Plugins: None activated
  • Plugins:
    • Test Reports 1.2.0

Actual Results

  1. ✅ Issue resolved with patch.

@parthvataliya
3 weeks ago

Twenty thirteen theme before patch

@parthvataliya
3 weeks ago

Twenty thirteen theme after patch

@parthvataliya
3 weeks ago

Twenty sixteen theme before patch

@parthvataliya
3 weeks ago

Twenty sixteen theme after patch

#4 @imranhasanraaz
3 weeks ago

Test Report

Description

This report validates whether the indicated patch works as expected. top border has been removed from both of the themes. 

Patch tested: https://core.trac.wordpress.org/attachment/ticket/62282/62282.1.patch

Environment

  • WordPress: 6.8-alpha-59274-src
  • PHP: 8.2.26
  • Server: nginx/1.27.2
  • Database: mysqli (Server: 8.0.40 / Client: mysqlnd 8.2.26)
  • Browser: Chrome 131.0.0.0
  • OS: Windows 11
  • Theme: Twenty Thirteen 4.3
  • MU Plugins: None activated
  • Plugins:
    • Test Reports 1.1.0

Actual Results

  1. ✅ Issue resolved with patch.

Theme: twenty thirteen
Before editor: https://prnt.sc/YOCumSKs6XSS
Before frontend : https://prnt.sc/PEOnYTrYTJle

After editor: https://prnt.sc/9KUgkgw8N32r
After frontend : https://prnt.sc/_Dd8tjINcpiO

Theme : Twenty Sixteen
Before editor: https://prnt.sc/6a8B_rY4PaoF
Before frontend : https://prnt.sc/tWH6P1N7nvHE

After editor: https://prnt.sc/88IfJQuVasGg
After frontend :https://prnt.sc/2pcIRqSmstUy

Last edited 3 weeks ago by imranhasanraaz (previous) (diff)

#5 @poena
12 days ago

  • Keywords commit added; needs-testing removed

#6 @poena
12 days ago

  • Owner set to poena
  • Resolution set to fixed
  • Status changed from new to closed

In 59476:

Twenty Thirteen & Twenty Sixteen: Correct the border of the latest comments block in the editor.

This change hides the top border of the first comment in the latest comments block, so that the design
in the editor and the front looks the same.

Props viralsampat, sabernhardt, aishwarryapande, parthvataliya, imranhasanraaz.
Fixes #62282.

Note: See TracTickets for help on using tickets.