Warning in WP_REST_Posts_Controller::get_items()

[apermo]

On my sentry installation I get Warning: Undefined array key "paged" for /wp/wp-includes/rest-api/endpoints/class-wp-rest-posts-controller.php in WP_REST_Posts_Controller::get_items at line 400

Same also technically applies to the WP_REST_Global_Styles_Revisions_Controller and WP_REST_Revisions_Controller.

A Github PR for this follows.

WP_REST_Revisions_Controller::get_items(), WP_REST_Posts_Controller::get_items() and WP_REST_Global_Styles_Revisions_Controller::get_items() can throw a warning if paged is not set in query_args

This PR fixes that, by duplicating and adjusting the same logic already present for offset in both Revisions controller, ensuring that the result in $page will still be 0 if it was empty, and the int value otherwise, just catching the warning.

Trac ticket: [](https://core.trac.wordpress.org/ticket/62292)

[Hemant Ahir]

Here's the concise solution for the warning Undefined array key "paged" in the WP_REST_Posts_Controller:

Solution: Add a check to verify if the "paged" parameter exists in the request before accessing it. If it's not present, assign a default value.

Fix (around line 400 in class-wp-rest-posts-controller.php):

<?php
$paged = isset( $request['paged'] ) ? absint( $request['paged'] ) : 1;
?>

This same logic can be applied to WP_REST_Global_Styles_Revisions_Controller and WP_REST_Revisions_Controller as well. This ensures that no warnings occur when the "paged" key is missing.

Closing in favor of #8021

[flixos90]

Great catch @apermo! The PR by @pbearne looks good. While I agree this is unrelated to performance, this is a worthwhile win. I'll take a closer look at the PR later.

[flixos90]

In 59630:

REST API: Fix PHP warning about undefined paged argument in various REST API endpoints.

This bug could occur in WP_REST_Posts_Controller, WP_REST_Global_Styles_Revisions_Controller, WP_REST_Revisions_Controller, and any of their child classes. This changeset fixes it throughout.

Props apermo, pbearne, hemant-ahir, flixos90.
Fixes #62292.

Committed in https://core.trac.wordpress.org/changeset/59630