Make WordPress Core

Opened 2 years ago

Closed 2 years ago

#62301 closed defect (bug) (fixed)

Twenty Twenty: Pullquote block does not show custom borders in the editor

Reported by: nidhidhandhukiya Owned by: poena
Priority: normal Milestone: 6.8
Component: Bundled Theme Version:
Severity: normal Keywords: has-patch commit
Cc: Focuses: css

Description

Steps to reproduce the issue :-

  1. Activate Twenty Twenty theme.
  2. Choose Pullquote block.
  3. Apply Border width and color.

Now check both the side in editor and front end border is diffrent.
In editor we don't have any border if we does not choose border-type.

Attachments (3)

62301.patch​ (1014 bytes ) - added by nidhidhandhukiya 2 years ago.
62301.1.patch​ (1.1 KB ) - added by sabernhardt 2 years ago.
switches border: none to border: 0 solid
Screenshot from 2024-10-29 14-10-05.png​ (317.5 KB ) - added by dhruvang21 2 years ago.

Download all attachments as: .zip

Change History (9)

#1 @divyeshk71
2 years ago

Hello @nidhidhandhukiya

Can you share any screenshot for reference?

Thanks.

#2 @ugyensupport
2 years ago

Twenty Twenty theme pullquote block

Description

Twenty Twenty theme pullquote block having design issue in editor side when border has selected.

Patch tested:

https://core.trac.wordpress.org/attachment/ticket/62301/62301.patch

Steps to reproduce

Activate Twenty Twenty theme.
Choose Pullquote block.
Apply Border width and color.
Now check both the side in editor and front end border is diffrent.
In editor we don't have any border if we does not choose border-type.

Environment

  • WordPress: 6.7-RC1
  • PHP: 8.3.10
  • Server: nginx/1.21.4
  • Database: mysqli (Server: 5.7.44-log / Client: mysqlnd 8.3.10)
  • Browser: Chrome 130.0.0.0
  • OS: macOS
  • Theme: Twenty Twenty 2.7
  • MU Plugins: None activated
  • Plugins:
    • Test Reports 1.1.0
    • WordPress Beta Tester 3.6.1

Actual Results

  1. ✅ Issue resolved with patch.

Supplemental Artifacts

Before patch : https://ibb.co/Q9SRrxf
After patch: https://ibb.co/s3pw5QC

@sabernhardt
2 years ago

switches border: none to border: 0 solid

#3 @sabernhardt
2 years ago

  • Focuses css added
  • Keywords has-patch added
  • Milestone Awaiting Review → 6.8
  • Summary Twenty Twenty theme pullquote block having design issue in editor side when border has selected. → Twenty Twenty: Pullquote block does not show custom borders in the editor
  • Version 6.6.2

Removing the border was important in an earlier version of WordPress. To continue supporting older versions, the value could be 0 solid instead (similar to [58469]).

#4 @dhruvang21
2 years ago

Test Report

Description

This report validates whether the indicated patch works as expected.

Patch tested: https://core.trac.wordpress.org/attachment/ticket/62301/62301.1.patch

Environment

  • WordPress: 6.8-alpha-59274-src
  • PHP: 8.2.22
  • Server: nginx/1.27.0
  • Database: mysqli (Server: 8.0.39 / Client: mysqlnd 8.2.22)
  • Browser: Chrome 128.0.0.0
  • OS: Linux
  • Theme: Twenty Twenty 2.7
  • MU Plugins: None activated
  • Plugins:
    • Test Reports 1.1.0

Actual Results

  1. ✅ Issue resolved with patch.

Supplemental Artifacts

Attached Screenshot after patch

#5 @poena
2 years ago

  • Keywords commit added

Test Report

This report validates that the indicated patch addresses the issue.

Patch tested: https://core.trac.wordpress.org/attachment/ticket/62301/62301.1.patch

Environment

  • WordPress: 6.8-alpha-59274-src
  • PHP: 7.4.30
  • Server: nginx/1.23.1
  • Database: mysqli (Server: 8.0.39 / Client: mysqlnd 7.4.30)
  • Browser: Chrome 130.0.0.0
  • OS: macOS
  • Theme: Twenty Twenty 2.8

Actual Results

  • ✅ Issue resolved with patch.

#6 @poena
2 years ago

  • Owner set to poena
  • Resolution → fixed
  • Status new → closed

In 59390:

Twenty Twenty: Correct the border style of the pull quote block in the editor.

This change makes the border of the pull quote block visible in the editor when the user selects a border color or thickness,
by setting the default border style to solid.

Props nidhidhandhukiya, ugyensupport, dhruvang21, sabernhardt, divyeshk71, poena.
Fixes #62301.

Note: See TracTickets for help on using tickets.