WordPress.org
Get WordPress

Make WordPress Core

Opened 6 weeks ago

Closed 6 weeks ago

#62306 closed defect (bug) (fixed)

Fix wrong instruction on revisions slider accessibility text

Reported by: pedromendonca's profile pedromendonca Owned by: peterwilsoncc's profile peterwilsoncc
Milestone: 6.7 Priority: normal
Severity: normal Version: 6.7
Component: Revisions Keywords: has-patch i18n-change commit dev-reviewed
Focuses: accessibility Cc:

Description

The hidden text "Change revision by using the left and arrow keys" is missing the word "right".

The correct string would be:
"Change revision by using the left and right arrow keys".

Here is the source code:
​https://github.com/WordPress/wordpress-develop/blob/43b64f581e39b7b1b087160c087b94fc70a8edc1/src/wp-admin/includes/revision.php#L383

Change History (10)

This ticket was mentioned in ​PR #7651 on ​WordPress/wordpress-develop by ​@pedromendonca.
6 weeks ago #1

  • Keywords has-patch added

Update the wording of the accessibility text on the revisions slider about using the left and right arrow keys.
Fix to: _Change revision by using the left and right arrow keys_

Trac ticket: https://core.trac.wordpress.org/ticket/62306

#2 @sabernhardt
6 weeks ago

  • Component changed from I18N to Revisions
  • Keywords i18n-change added
  • Milestone changed from Awaiting Review to 6.7

@fierevere also mentioned this ​on Slack.

The new string is part of [59225].

#3 @swissspidy
6 weeks ago

  • Keywords commit added

cc @joedolson

#4 @peterwilsoncc
6 weeks ago

  • Owner set to peterwilsoncc
  • Resolution set to fixed
  • Status changed from new to closed

In 59306:

Revisions: Fix typo in navigation help text.

Fixes a typo in the a11y helper text explaining how to navigate revisions. "Change revision by using the left and arrow keys" becomes "Change revision by using the left and right arrow keys".

Follow up to [59225].

Props pedromendonca, sabernhardt, fierevere, swissspidy.
Fixes #62306.

#6 @peterwilsoncc
6 weeks ago

  • Keywords dev-feedback added
  • Resolution fixed deleted
  • Status changed from closed to reopened

Reopening for merge to the 6.7 branch following sign-off by another committer.

This ticket was mentioned in ​Slack in #core by chaion07. ​View the logs.
6 weeks ago

#8 @swissspidy
6 weeks ago

  • Keywords dev-reviewed added; dev-feedback removed

#9 @joedolson
6 weeks ago

Thanks for the ping @swissspidy, and for taking care of this, @peterwilsoncc.

#10 @peterwilsoncc
6 weeks ago

  • Resolution set to fixed
  • Status changed from reopened to closed

In 59313:

Revisions: Fix typo in navigation help text.

Fixes a typo in the a11y helper text explaining how to navigate revisions. "Change revision by using the left and arrow keys" becomes "Change revision by using the left and right arrow keys".

Follow up to [59225].

Reviewed by swissspidy.
Merges [59306] to the 6.7 branch.

Props pedromendonca, sabernhardt, fierevere, swissspidy.
Fixes #62306.

Note: See TracTickets for help on using tickets.