wp_image_src_get_dimensions() - Warning for SVG with postmeta height and width empty

[apermo]

As @donbowman pointed out originally in https://core.trac.wordpress.org/ticket/57813#comment:2 wp_image_src_get_dimensions() will throw a warning and have potentially broken results when used with an SVG.

After a short conversation with @soean, he followed my suggestion to split this topic up into an individual ticket, since this one is frontend related, the other is not.

I will prepare a PR on github, following @donbowman's initial findings.

As originally pointed out by @donbowman, wp_image_src_get_dimensions() will not work properly for SVG, since they do not have sizes added to post meta. This is his original patch taken from https://core.trac.wordpress.org/ticket/57813#comment:2, just fixed the checks.

Optionally we could consider to check the mimetype here. Any thoughts on that?

Trac ticket: https://core.trac.wordpress.org/ticket/62312#ticket

[joesimpsonjr]

@apermo to move forward, we need testing instructions.

For example, "upload an SVG without dimensions" and report how it looks. We need clear step-by-step instructions on how to reproduce the bug and steps to test the patch.

Thank you.

[apermo]

@joesimpsonjr I haven't found this bug myself. As mentioned this is by @donbowman see https://core.trac.wordpress.org/ticket/57813#comment:2

So I can't provide a step by step guide sadly.

[joesimpsonjr]

@apermo I'd like to test the patch but cannot check that the patch is working without it. What steps did you use with your patch? Again, thanks.