#62323 closed defect (bug) (fixed)
Sass Deprecation warnings during build process with v 1.80.x
Reported by: |
|
Owned by: |
|
---|---|---|---|
Milestone: | 6.8 | Priority: | normal |
Severity: | normal | Version: | 6.7 |
Component: | Administration | Keywords: | has-patch commit |
Focuses: | Cc: |
Description
Follow up to #62142
SASS has deprecated global functions and also the @import
rule, see here:
https://sass-lang.com/documentation/breaking-changes/import/
https://sass-lang.com/documentation/at-rules/import/
Fixes for this have been created in a PR for ClassicPress and we are sharing this back should you wish to consider the same solution.
Patch files for the 2 commits are attached and the original PR is here:
Attachments (2)
Change History (10)
#2
@
6 months ago
- Keywords has-patch added
- Owner set to desrosj
- Status changed from new to reviewing
This ticket was mentioned in PR #8100 on WordPress/wordpress-develop by @desrosj.
4 months ago
#3
#4
@
3 months ago
- Keywords commit added
Thanks for this, @MattyRob!
The patch did not apply correctly, but I went ahead and created the attached PR to test it out.
DEPRECATION WARNING [user-authored]: The legacy JS API is deprecated and will be removed in Dart Sass 2.0.0.
There are still several of these warnings, but I think this is due to grunt-sass
not yet accounting for the changes upstream. There is an open issue and even a fork with the fix published as grunt-sass-modern.
I double checked the built files, and no unexpected CSS changes resulted. Will confirm after committing.
#8
@
3 months ago
Confirmed there are no changes to .css
files after [59656]: https://build.trac.wordpress.org/changeset/58999.
Trac ticket: https://core.trac.wordpress.org/ticket/62323