Make WordPress Core

Changes between Version 1 and Version 2 of Ticket #62337, comment 37


Ignore:
Timestamp:
11/19/2024 11:07:21 AM (5 months ago)
Author:
timwhitlock
Comment:

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #62337, comment 37

    v1 v2  
    1010So to answer your question - **I can't call `unload_textdomain`**, because my code won't run until hooks fire. Which they now don't. Only the text domain provider can make that fix. My users will be lucky if that happens fast enough, or at all.
    1111
    12 In order to restore previous functionality myself I would have have to forcefully unload all text domains when my plugin starts up. I don't want to do that, partly for performance. But if 6.7.1 doesn't rectify the issue I may have to.
     12In order to restore previous functionality myself, I would have to forcefully unload all text domains when my plugin starts up. I don't want to do that, partly for performance. But if 6.7.1 doesn't rectify the issue I may have to.
    1313
    1414It's worth noting that unloading NOOP translations does indeed cover a lot of the most common cases, but not all of them. I don't see a good reason to be so selective, other than to protect the performance gains for which this change was [I assume] primarily made. I respect the need for performance, but not at the expense of broken websites.