Edit site, Ambiguity and inconsistency of the admin bar link to the site editor

[mosne]

Have you ever accidentally clicked on "edit site" instead of "edit page"?
I've been working extensively with block themes lately, and I find myself making this mistake often, even though I clearly know the difference between the two buttons. After asking around, it seems I'm not the only one.

Secondly, when I'm in the admin area working on a block theme, I always look for the "Edit site" button, but it's not there. Instead, I have to navigate to Appearance > Editor.

Here's my simple proposition:

• The link is always called "Editor"
• The link is always visible if you have activated a block theme.

It's a small change, but it would greatly improve the user experience!

Trac ticket: core 62368

## Summary
Edit site, Ambiguity and inconsistency of the admin bar link to the site editor:
Have you ever accidentally clicked on "edit site" instead of "edit page"?
I've been working extensively with block themes lately, and I find myself making this mistake often, even though I clearly know the difference between the two buttons. After asking around, it seems I'm not the only one.

Secondly, when I'm in the admin area working on a block theme, I always look for the "Edit site" button, but it's not there. Instead, I have to navigate to Appearance > Editor.

Here's my simple proposition:

The link is always called "Editor"
The link is always visible if you have activated a block theme.
It's a small change, but it would greatly improve the user experience!

## Changers

• Renamed 'Edit site' to 'Editor'
• Provide a shortcut link to the editor in the admin

[poena]

Hi @mosne This problem is already discussed in detail and managed here: ​https://github.com/WordPress/gutenberg/issues/63785

Updating it in the Gutenberg plugin allows for earlier testing, since the plugin has more frequent releases than WordPress. Once the fix is released as part of WordPress, and the plugin uses that version as the minimum required WordPress version, the code is removed from the plugin.

The two solutions need to be identical.

[sabernhardt]

This Trac ticket probably could be closed as 'reported-upstream', but I put it in the Toolbar component.

[poena]

In my opinion, the link to the template should be removed, as proposed and discussed in the Gutenberg issue. It should match the the Editor link under Appearance.

There is a plan to update the Site Editor paths in WordPress 6.8.
Please see https://core.trac.wordpress.org/ticket/62585
So if the link is not removed, it may be worth updating the query args so that no redirect needs to happen.

Trac ticket: https://core.trac.wordpress.org/ticket/62368

This is the backport of ​https://github.com/WordPress/gutenberg/pull/69271

This PR changes the Edit Site link in the admin bar to point to the top level (the "home") of the Site Editor, instead of opening the current template.

Based on feedback in https://core.trac.wordpress.org/ticket/62368, the Edit Site link also shows in the admin area.
Showing the link while in the admin area makes the admin bar more consistent and makes it easier to use, since you can use your muscle memory.

Testing Instructions
Activate a block theme.
Confirm that the Edit Site link shows in the admin bar, and that it leads to the Site Editor, without opening a specific template.
Activate a classic theme and confirm that the link does not show.

This changeset looks good on my side 👍

## Before

## After

[shailu25]

Test Report

Patch Tested: ​https://github.com/WordPress/wordpress-develop/pull/8372

Environment:
WordPress - 6.8-alpha-59859
OS - Windows
Browser - Firefox
Theme: Twenty Twenty Five
PHP - 8.2.12
Active Plugin: WordPress Beta Tester

Actual Results:

• Issue Resolved with patch.✅

Screenshots:

• Added Attachment

[shailu25]

Before Patch

[shailu25]

After Patch

[audrasjb]

Self assigning for final review and commit.

[audrasjb]

In 59910:

Admin bar: Update the "Edit Site" link.

This changeset replaces the "Edit Site" link in the admin bar to point to the top level screen of the Site Editor, instead of opening the current template.
Merges Gutenberg changeset: WordPress/gutenberg#69271

Props mosne, poena, audrasjb, shailu25.
Fixes #62368.