Untranslatable texts in admin nav-menu.js

[juliemoynat]

In WordPress 6.7, this ticket #43305 has been fixed. Two select fields have been added in the "Appearance > Menus" admin page.

In these select fields, there are options with English words that are added in "wp-admin\js\nav-menu.js":

• "No Parent"
• "of" (for "1 of 5")

They are raw texts and not translatable strings.

[swissspidy]

cc @joedolson

### Description
Updated raw strings to use i18n functions.

Trac ticket: https://core.trac.wordpress.org/ticket/62402

[desrosj]

Added a review on the PR, but it seems that two of the strings should maybe use wp.i18n._x instead of wp.i18n.__ to provide additional context to translators? It may not be clear what is being translated.

[tobifjellner]

_x() may not be needed, IF:

1. The string is only used once (or in the same way wherever it occurs), and
2. adding a Translators: comment works.

Strings like "x of y", is usually best to build with fprint(), if possible. And still with a clarifying comment.

[audrasjb]

_x is effectively needed if we can't add a translator comment, which is probably the case, here.

[SergeyBiryukov]

Replying to tobifjellner:

Strings like "x of y", is usually best to build with fprint(), if possible.

Indeed, wp.i18n.sprintf() should be used there.

Thanks, @desrosj for suggesting an improvement here.

Sure, it would be better to provide context to the translator. I've added a patch for the same. Thanks.

@yogeshbhutkar one more change! @SergeyBiryukov confirmed in track that wp.i18n.sprintf() is actually the correct function.

Thanks, @desrosj.

The changes are appended to the PR.

[joedolson]

I made a minor change for readability, but I think this is good to go.

[joedolson]

In 59426:

Menus: i18n: Fix untranslatable strings in nav-menu.js.

Wrap three untranslatable strings in nav menus in JS translation functions.

Follow up to [59265].

Props juliemoynat, swissspidy, yogeshbhutkar, sergeybiryukov, desrosj, tobifjellner, audrasjb, joedolson.
Fixes #62402.

[joedolson]

Re-opening for dev review and commit to 6.7.1.

[desrosj]

Thanks @joedolson. Looks good to backport.

[desrosj]

In 59428:

Menus: i18n: Fix untranslatable strings in nav-menu.js.

Wrap three untranslatable strings in nav menus in JS translation functions.

Follow up to [59265].

Reviewed by desrosj, joedolson.
Merges 59426 to the 6.7 branch.

Props juliemoynat, swissspidy, yogeshbhutkar, sergeybiryukov, desrosj, tobifjellner, audrasjb, joedolson.
Fixes #62402.

[SergeyBiryukov]

In 59431:

I18N: Adjust translator comments in nav-menu.js.

Includes:

• Moving the comments directly above wp.i18n._x() so that they can be picked up properly.
• Simplifying the context to avoid unnecessarily translating the string twice for the same use case.
• Using the established translator comments format for consistency.

Follow-up to [59428].

See #62402.

[SergeyBiryukov]

Just some minor cleanup for translator comments in [59431], reopening for a second committer's review.

[desrosj]

Thank you, @SergeyBiryukov! Looks good. Backporting now.

[desrosj]

In 59432:

I18N: Adjust translator comments in nav-menu.js.

Includes:

• Moving the comments directly above wp.i18n._x() so that they can be picked up properly.
• Simplifying the context to avoid unnecessarily translating the string twice for the same use case.
• Using the established translator comments format for consistency.

Follow-up to [59428].

Reviewed by SergeyBiryukov, desrosj.
Merges [59431 to the 6.7 branch.

Fixes #62402.

Merged in https://core.trac.wordpress.org/changeset/59426 & https://core.trac.wordpress.org/changeset/59431.